Do not parse DNX stuff as dotnetcoreapp - fixes #3544 #3545
Conversation
forki
force-pushed
the
i3544
branch
10 times, most recently
from
521fade to
eaad940
Compare
There was a problem hiding this comment.
Can you briefly explain what the root cause is and what the fix here does. Maybe it's because I just woke up but I don't get it (I looked at the referenced issue #3544 but I'm not exactly sure why removing a framework would break the resolution)
| @@ -372,7 +372,7 @@ module LockFileParser = | |||
| | e -> | |||
| try InstallSettings.Parse(true, "framework: " + settingsPart) // backwards compatible | |||
| with e2 -> | |||
| raise <| AggregateException(sprintf "failed to parse line '%s'" line, e, e2) | |||
| raise <| AggregateException(sprintf "failed to parse line '%s'. Message: %s" line e2.Message, e, e2) | |||
There was a problem hiding this comment.
There shouldn't be a need for these changes as the error reporter at the end outputs all inner exception. If there is a need for these kind of changes we failed to propagate error information correctly and we should fix that instead.
There was a problem hiding this comment.
I think this was my mistake. I didn't read the message top to bottom and so I thought this would be needed,
|
my latest fix which tried to remove DNX was a bit too lazy. I just set it equal with dotnet core 1. |
|
we don't warn. with next paket install the crap gets nuked anyway... |
No description provided.