-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paket 5.203.2 pulls packages it shouldn't pull -> build fails #3566
Comments
So it seems to be related to the fact that we have a Not sure why the previous fix doesn't work |
I think this might be related to the filtering: I think restriction groups without "framework" are considered "generic" groups which "match everything" (see #3556 (comment)). It feels like this is happening here: We consider the @forki any change to take a look? |
To reproduce run
Now inspect the lockfile and see that paket "thinks" |
With
Which is the expected result. Maybe we should add a test for this. |
Yes if you like it you should put a ring on it. Beyoncé Driven Development
Matthias Dittrich <[email protected]> schrieb am Sa., 11. Mai 2019,
11:54:
… With version 5.206.0 this now creates:
RESTRICTION: == netstandard2.0
NUGET
remote: https://api.nuget.org/v3/index.json
Microsoft.CSharp (4.5)
Which is the expected result. Maybe we should add a test for this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3566 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAOANFJYBRMBZSEHYUGQBDPU2JVLANCNFSM4HKUKTLQ>
.
|
Description
Just updated paket and now run into a issue similar to #3544 but for a
net461
project:This is probably related to #3545 or #3530 (or both)
The following changes make me suspicious in the lockfile:
I think there is a second bug here, because even considering paket pulling the dependencies (as there might be frameworks which need it) it should filter them when considering a project building for
net461
. I'm wondering why people are not reporting this issue more often.Expected behavior
Paket shouldn't think
Microsoft.CSharp
has dependencies in this situation.Actual behavior
Paket thinks
Microsoft.CSharp
has dependencies.Known workarounds
Downgrade to
5.198.0
The text was updated successfully, but these errors were encountered: