Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not change the AutoGenerateBindingRedirects for exe output type #3471

Merged
merged 1 commit into from
Jan 13, 2019
+4 −3
Merged

Do not change the AutoGenerateBindingRedirects for exe output type #3471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Paket.Core/Installation/BindingRedirects.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,10 @@ let private applyBindingRedirects isFirstGroup cleanBindingRedirects (allKnownLi
use f = File.Open(configFilePath, FileMode.Create)
config.Save(f, SaveOptions.DisableFormatting)

match projectFile.GetAutoGenerateBindingRedirects() with
| Some x when x.ToLower() = "true" -> ignore()
| _ -> projectFile.SetOrCreateAutoGenerateBindingRedirects()
match projectFile.OutputType, projectFile.GetAutoGenerateBindingRedirects() with
| ProjectOutputType.Exe, _ -> ignore()
| _, Some x when x.ToLower() = "true" -> ignore()
| _, _ -> projectFile.SetOrCreateAutoGenerateBindingRedirects()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not the last branch also check that redirects is not set to off?


let findAllReferencesFiles root =
let findRefFile (p:ProjectFile) =
Expand Down