Do not change the AutoGenerateBindingRedirects for exe output type #3471
Conversation
|
Are these failures related to my change? I can't see how they are...i ran the build locally and they go green. |
|
@forki any chance fmof getting this (or something similar) in? Causing me issues when I forget to revert |
|
@forki Any reason why this option should not be left alone for DLLs as well, not just for EXE? We are facing the same issue with our Web projects (DLL). Paket resets |
| match projectFile.OutputType, projectFile.GetAutoGenerateBindingRedirects() with | ||
| | ProjectOutputType.Exe, _ -> ignore() | ||
| | _, Some x when x.ToLower() = "true" -> ignore() | ||
| | _, _ -> projectFile.SetOrCreateAutoGenerateBindingRedirects() |
There was a problem hiding this comment.
Should not the last branch also check that redirects is not set to off?
|
Originally this was put to suppress build warnings. I'm starting to think actually we should remove since msbuild appears to have been fixed |
This has some weird behavior when you set to true on exe output types.
It's safer to leave them alone and let the user decide to enable if they wish.
Currently, i am having to revert the paket change so as to keep my actual redirects rather than those auto generated.
Stupidly in MSBuild, this switch is ONLY used in exe output types to generate the redirects.
But when set on Library output types, it prevents warnings...slow clap for msbuild using the same property for 2 tasks...