add .net sdk preview3 fsprojs to core3

[enricosada]

using .net core sdk 1.0.0-preview3-004007

To test:

• build paket build (becuase some paket files are rrequired as sources)
• cd src\Paket.Core
• dotnet restore Paket.Core.preview3.fsproj
• dotnet build Paket.Core.preview3.fsproj

[enricosada]

Atm i get one error

         ProjectFile.fs(1341,35): error FS0039: The record label or namespace 'PackagesConfigFile' is not defined [e:\github\Paket\src\Paket.Core\Paket.Core.preview3.fsproj]

same error if i build src\Paket.Core\Paket.Core project.json with preview2, so is just something new @forki @matthid @theimowski ?

[enricosada]

Nvm fixed :D

• Paket.Core.preview3 is ok

works with dotnet pack Paket.Core.preview3.fsproj too

[enricosada]

ok, done.

the Paket console build and run as netcoreapp1.0 (.net core).
I #ifdef'ed some stuff, review it, like:

• Environment.Exit not supported, commented out atm, easy way is to refactor and use a global static
• the version check i dont understand what's used for, so i used a default

The Paket.Core is p2p ref, so if need rebuild is rebuilt when Paket is built.

• cd src\Paket
• dotnet restore Paket.preview3.fsproj
• dotnet run -p Paket.preview3.fsproj -- --help

[forki]

rebased it on master and will take a look tomorrow. thanks buddy

[matthid]

Can we use this in both cases and remove the #if?

[forki]

jupp will do

[forki]

ok this is pretty cool.
Restore and Build seem to work on master. @enricosada could you please take a look on Pack? I commented it out for now

[forki]

Microsoft.FSharp.Core.netcore is that stuff merged into FSharp.Core alpha package?
/cc @dsyme @enricosada @KevinRansom

[enricosada]

Try workaround for pack https://github.com/dotnet/netcorecli-fsc/blob/master/examples/preview3/console-crossgen/README.md

Yes is the same. Use fsharp.core if you want.

[enricosada]

There are issues with fsharp.core a netcore but less discuss later.

[forki]

[enricosada]

@forki i'll check later.
Workaround was for crossgen (net46+netcoreapp).
I need to add the use case dotnet pack of console netcoreapp to netcorecli-fsc test suite too :)

[forki]

Cool. I'll commented it out for now.

Am 05.11.2016 12:58 nachm. schrieb "Enrico Sada" [email protected]:

@forki https://github.com/forki i'll check later.
Workaround was for crossgen (net46+netcoreapp).
I need to add the use case dotnet pack of console netcoreapp to
netcorecli-fsc test suite too :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2004 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNB1hon8UpyTfG-wHp0teH2IgeWm1ks5q7G9egaJpZM4KprLb
.

[forki]

https://ci.appveyor.com/project/SteffenForkmann/paket/branch/master

The specified deps.json [C:\Users\appveyor\.nuget\packages\.tools\dotnet-compile-fsc\1.0.0-preview2-020000\netcoreapp1.0\dotnet-compile-fsc.deps.json] does not exist

what does that mean?

[forki]

<PackageReference Include="FSharp.NET.Sdk">
  <Version>1.0.0-alpha-000001</Version>
  <PrivateAssets>All</PrivateAssets>
</PackageReference>

what does PrivateAssets mean and is it needed?

[enricosada]

It's new of nuget spec for references AFAIK.
check the generated nuspec inside package.
I see Three values: Code(something like that)/analyzer/build.
All mean to restore also build (msbuild targets i think).
I didnt searched more details becuase doesnt matter for me but i think works like that.
If you Explore more and find more info, pls send a link to me too.

[enricosada]

Deps.json error dunno why happen. I'll check