WIP Make Paket work with dotnet cli preview3 #1977

forki · 2016-10-24T11:19:32Z

- Make "paket install" hook into MSBuild 15 / dotnet cli preview3 restore
- Make Paket restore it's own PaketRestoreTask.dll
- Do not emit dll references for MSBuild 15 projects
- Use magic mode
- Make everything work in ionide
- Make Paket create it's own Nuget.Config or hook into that in MSBuild
- Convert from Nuget should read / remvoe PackageReferences from *proj - (@theimowski ?)

matthid

Looks good.

matthid · 2016-10-24T20:51:34Z

build.sh

-  exit_code=$?
-  if [ $exit_code -ne 0 ]; then
-    certificate_count=$(certmgr -list -c Trust | grep X.509 | wc -l)
-    if [ $certificate_count -le 1 ]; then


I think we might still need this, just later at the paket.exe call...

matthid · 2016-10-24T20:55:17Z

src/Paket.Core/LockFile.fs

            for p in g.NugetPackages do
                let k = groupName,p.Name
                if usedPackages.ContainsKey k then
                    failwithf "Package %O is referenced more than once in %s within group %O." p.Name referencesFile.FileName groupName
                usedPackages.Add(k,p)

            g.NugetPackages
-            |> List.iter (fun package -> 
+            |> List.iter (fun package ->                 


matthid · 2016-10-24T21:02:53Z

src/PaketRestoreTask/Program.cs

+
+namespace Paket.Build.Tasks
+{
+    public class PaketRestoreTask : Task


Just some crasy thinking: Would it make sense to think about extension points in paket?

Considering all those different use cases we might have soon (dotnetcore, toml, legacy, fable?) shouldn't we try to get things like these out of paket core into modules or something like that?

sure. bringe them on

forki · 2016-10-25T10:04:09Z

theimowski · 2016-10-25T15:43:56Z

Re convert - there's no packages.config anymore, but rather every dep is moved to *proj? Is it a 1-1 mapping?

forki · 2016-10-25T15:45:07Z

It's looking like this now:

<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" />
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp1.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <Compile Include="**\*.cs" />
    <EmbeddedResource Include="**\*.resx" />
  </ItemGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.NETCore.App">
      <Version>1.0.1</Version>
    </PackageReference>
    <PackageReference Include="Microsoft.NET.Sdk">
      <Version>1.0.0-alpha-20161019-1</Version>
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>
  </ItemGroup>
  <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
</Project>

theimowski · 2016-10-25T15:48:14Z

I can give it a try, but can take a week or two - little spare time right now

forki · 2016-10-25T15:48:59Z

yeah don't worry. no need to hurry

theimowski · 2016-11-01T07:18:00Z

which dotnet core build you're using? Is it 1.0.0-preview3-003884?
How to download that build @enricosada ?
I tried https://dotnetcli.blob.core.windows.net/dotnet/Sdk/rel-1.0.0/dotnet-dev-win-x64.1.0.0-preview3-003884.zip but that was a miss

With the latest dotnet (https://dotnetcli.blob.core.windows.net/dotnet/Sdk/rel-1.0.0/dotnet-dev-win-x64.latest.zip), when I try to repro your showcase, I get

forki · 2016-11-01T07:19:48Z

@theimowski you must run paket install once before you can restore.

theimowski · 2016-11-01T07:39:01Z

Thanks, that was the case. Also turns out, in latest dotnet core there's no more "3" suffix for commands https://github.com/dotnet/cli/issues/4205

…1977

theimowski · 2016-11-03T06:36:33Z

I'm hacking around convert - pushing changes directly to this branch - is it fine with you?
What I'm struggling with is:
Paket failed with: Could not find versions for package Microsoft.NET.Sdk on any of ["https://www.nuget.org/api/v2"; "http://api.nuget.org/v3/index.json"].
which should probably work, as dotnet restore outputs: Feeds used: https://api.nuget.org/v3/index.json

forki · 2016-11-03T06:38:59Z

Yes that's fine. Maybe we need another feed. @enricosada?

forki · 2016-11-03T12:01:29Z

maybe https://github.com/dotnet/netcorecli-fsc/blob/master/examples/preview3/console/NuGet.Config#L4 ?

enricosada · 2016-11-03T12:20:41Z

https://github.com/dotnet/netcorecli-fsc/blob/master/examples/preview3/lib/NuGet.Config

Sent from mobile

From: Steffen Forkmann [email protected]
Sent: Thursday, November 3, 2016 7:39:01 AM
To: fsprojects/Paket
Cc: Enrico Sada; Mention
Subject: Re: [fsprojects/Paket] WIP Make Paket work with dotnet cli preview3 (#1977)

Yes that's fine. Maybe we need another feed. @enricosadahttps://github.com/enricosada?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/1977#issuecomment-258073022, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAI_Ky2zzbqroMH9hJjaaMg4EII-hfduks5q6YGFgaJpZM4Keq6C.

enricosada · 2016-11-03T12:29:26Z

Also the dotnet sdk feeds

https://github.com/dotnet/cli/blob/rel/1.0.0/NuGet.Config

Sent from mobile

From: Steffen Forkmann [email protected]
Sent: Thursday, November 3, 2016 1:01:30 PM
To: fsprojects/Paket
Cc: Enrico Sada; Mention
Subject: Re: [fsprojects/Paket] WIP Make Paket work with dotnet cli preview3 (#1977)

maybe https://github.com/dotnet/netcorecli-fsc/blob/master/examples/preview3/console/NuGet.Config#L4 ?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/1977#issuecomment-258124337, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAI_K0jDV_NNHdHqC9fEaNX8c47Jmw9_ks5q6c0agaJpZM4Keq6C.

forki · 2016-11-03T12:37:41Z

@theimowski we can consume v3 API. just make sure all the nuget feeds are added to paket.deps and I think it's without the last part of the url

theimowski · 2016-11-03T12:40:51Z

yeah sorry my fault - didn't spot last @enricosada comment. It seems it's resolving deps now with those 4 additional feeds, but taking ages...

forki · 2016-11-03T12:42:37Z

@theimowski welcome to the brave new world of dotnet shipping via nuget

theimowski · 2016-11-03T13:13:16Z

Huh...

c:\sandbox\core3paket (master)
λ paket convert-from-nuget --force
Paket version 4.0.0-alpha021
Adding Microsoft.NET.Sdk 1.0.0-alpha-20161026-2 to c:\sandbox\core3paket\paket.dependencies into group Main
Adding Microsoft.NETCore.App 1.0.1 to c:\sandbox\core3paket\paket.dependencies into group Main
Dependencies files saved to c:\sandbox\core3paket\paket.dependencies
Resolving packages for group Main:
 - Microsoft.NETCore.App is pinned to 1.0.1
 - Microsoft.NET.Sdk is pinned to 1.0.0-alpha-20161026-2
 - newtonsoft.json 9.0.1
 - ...
Locked version resolution written to c:\sandbox\core3paket\paket.lock
Downloading ...
Garbage collecting ...
34 minutes, 5 seconds - ready.

and that's for just 3 deps:

source https://www.nuget.org/api/v2
source https://api.nuget.org/v3/index.json
source https://www.myget.org/F/xunit/api/v3/index.json
source https://www.myget.org/F/netcorecli-fsc-preview3/api/v3/index.json
source https://dotnet.myget.org/F/dotnet-core/api/v3/index.json
source https://dotnet.myget.org/F/cli-deps/api/v3/index.json
nuget Microsoft.NET.Sdk 1.0.0-alpha-20161026-2 alpha
nuget Microsoft.NETCore.App 1.0.1
nuget newtonsoft.json

forki · 2016-11-03T13:14:45Z

how fast is second update?

theimowski · 2016-11-03T13:16:48Z

you mean running now paket install --force ?

enricosada · 2016-11-03T13:19:47Z

Cold cache.
The sdk and packages ship with .net core sdk package so usually is not a problem.

And other packages are from nuget.orghttp://nuget.org so faster.
It's possible to tweak the feeds, and use less big feeds.
Or create a new feed for paket-dev with mirror of useful packages.
Pretty much all are in nuget.orghttp://nuget.orgv (minus msbuild/xunit dev/fsharp.sdk)

Sent from mobile

From: Tomasz Heimowski [email protected]
Sent: Thursday, November 3, 2016 2:13:18 PM
To: fsprojects/Paket
Cc: Enrico Sada; Mention
Subject: Re: [fsprojects/Paket] WIP Make Paket work with dotnet cli preview3 (#1977)

Huh...

c:\sandbox\core3paket (master)
? paket convert-from-nuget --force
Paket version 4.0.0-alpha021
Adding Microsoft.NET.Sdk 1.0.0-alpha-20161026-2 to c:\sandbox\core3paket\paket.dependencies into group Main
Adding Microsoft.NETCore.App 1.0.1 to c:\sandbox\core3paket\paket.dependencies into group Main
Dependencies files saved to c:\sandbox\core3paket\paket.dependencies
Resolving packages for group Main:

Microsoft.NETCore.App is pinned to 1.0.1
Microsoft.NET.Sdk is pinned to 1.0.0-alpha-20161026-2
newtonsoft.json 9.0.1
...
Locked version resolution written to c:\sandbox\core3paket\paket.lock
Downloading ...
Garbage collecting ...
34 minutes, 5 seconds - ready.

and that's for just 3 deps:

source https://www.nuget.org/api/v2
source https://api.nuget.org/v3/index.json
source https://www.myget.org/F/xunit/api/v3/index.json
source https://www.myget.org/F/netcorecli-fsc-preview3/api/v3/index.json
source https://dotnet.myget.org/F/dotnet-core/api/v3/index.json
source https://dotnet.myget.org/F/cli-deps/api/v3/index.json
nuget Microsoft.NET.Sdk 1.0.0-alpha-20161026-2 alpha
nuget Microsoft.NETCore.App 1.0.1
nuget newtonsoft.json

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/1977#issuecomment-258138209, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAI_K9Y8SIJz7RD4mHY04te9cYIkm5IXks5q6d3ugaJpZM4Keq6C.

forki · 2016-11-03T13:21:44Z

@theimowski no --force would take same time (since it skips cache). just run paket update

theimowski · 2016-11-03T13:27:15Z

56 seconds - ready.
much better ;)

How does it work now? Paket downloads the nupkgs to ./packages dir and then copies them to %HOME%.nuget.packages ?
Or do we somehow tell dotnet to take deps from "./packages"?

forki · 2016-11-03T13:32:14Z

Currently we download to both locations.

Am 03.11.2016 14:27 schrieb "Tomasz Heimowski" [email protected]:

56 seconds - ready.
much better ;)

How does it work now? Paket downloads the nupkgs to ./packages dir and
then copies them to %HOME%.nuget.packages ?
Or do we somehow tell dotnet to take deps from "./packages"?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1977 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNHaPgRs3i1f177zqcLHIDX96qRnBks5q6eEzgaJpZM4Keq6C
.

enricosada · 2016-11-04T15:39:53Z

ok i started the work in #2004
so Paket.Core is ok atm, working on Paket

collect multiple install errors before failing

version bump

# Conflicts: # RELEASE_NOTES.md # src/Paket.Bootstrapper/Properties/AssemblyInfo.cs # src/Paket.Core/AssemblyInfo.fs # src/Paket.PowerShell/AssemblyInfo.fs # src/Paket/AssemblyInfo.fs

forki force-pushed the core3 branch from 364323a to 8ceada6 Compare October 24, 2016 12:29

forki force-pushed the master branch from 14fa5b1 to c721b7a Compare October 24, 2016 15:39

matthid approved these changes Oct 24, 2016

View reviewed changes

theimowski added a commit that referenced this pull request Nov 3, 2016

convert - try to read PackageReferences of new MsBuild - references #…

17f6538

…1977

enricosada added 2 commits November 4, 2016 16:58

fix preview2 project.json

fecd914

cleanup

22ea7c2

forki and others added 28 commits March 9, 2017 08:01

Merge pull request #2177 from cloudRoutine/collect-errors

1212680

collect multiple install errors before failing

version bump

95c7ccb

Merge pull request #2181 from cloudRoutine/core3

38d637a

version bump

RELEASE_NOTES

45b8a33

Update all deps

a4a2777

Bump version to 4.0.0-rc1

8379820

Allow to append to groups

d94ab9a

Bump version to 4.0.0-rc2

7681e29

Fix GetToolsVersion

6194d99

Bump version to 4.0.0-rc3

1f3d6bb

Update FAKE

3007538

Merge branch 'master' into core3

3751e41

# Conflicts: # RELEASE_NOTES.md # src/Paket.Bootstrapper/Properties/AssemblyInfo.cs # src/Paket.Core/AssemblyInfo.fs # src/Paket.PowerShell/AssemblyInfo.fs # src/Paket/AssemblyInfo.fs

Merge branch 'master' into core3

4be0c3e

# Conflicts: # RELEASE_NOTES.md # src/Paket.Bootstrapper/Properties/AssemblyInfo.cs # src/Paket.Core/AssemblyInfo.fs # src/Paket.PowerShell/AssemblyInfo.fs # src/Paket/AssemblyInfo.fs

fix build

63288d7

Bump version to 4.0.0-rc4

38c067a

Fix missing values

2c0f9b4

fix test

941e69a

Depend on CollectPackageReference - references #2086

3521d68

Use netstandard1.3 - references #2086

d91e4d6

Bump version to 4.0.0-rc5

d3ef937

fix typo

2938ea7

Bump version to 4.0.0-rc6

516c833

fix typo

95a753f

Bump version to 4.0.0-rc7

74d2a39

Detect sdk versions - fixes #2182

91241ea

Bump version to 4.0.0-rc8

9bdc929

Detect sdk versions - fixes #2182

05e9caf

Bump version to 4.0.0-rc9

e198b7f

forki merged commit e198b7f into master Mar 15, 2017

matthid deleted the core3 branch May 6, 2017 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP Make Paket work with dotnet cli preview3 #1977

WIP Make Paket work with dotnet cli preview3 #1977

forki commented Oct 24, 2016 •

edited

Loading

matthid left a comment

matthid Oct 24, 2016

forki Oct 25, 2016

matthid Oct 24, 2016

matthid Oct 24, 2016

forki Oct 25, 2016

forki commented Oct 25, 2016

theimowski commented Oct 25, 2016

forki commented Oct 25, 2016

theimowski commented Oct 25, 2016

forki commented Oct 25, 2016

theimowski commented Nov 1, 2016

forki commented Nov 1, 2016

theimowski commented Nov 1, 2016

theimowski commented Nov 3, 2016

forki commented Nov 3, 2016

forki commented Nov 3, 2016

enricosada commented Nov 3, 2016

enricosada commented Nov 3, 2016

forki commented Nov 3, 2016

theimowski commented Nov 3, 2016

forki commented Nov 3, 2016

theimowski commented Nov 3, 2016

forki commented Nov 3, 2016

theimowski commented Nov 3, 2016

enricosada commented Nov 3, 2016

forki commented Nov 3, 2016

theimowski commented Nov 3, 2016 •

edited

Loading

forki commented Nov 3, 2016

enricosada commented Nov 4, 2016 •

edited

Loading

WIP Make Paket work with dotnet cli preview3 #1977

WIP Make Paket work with dotnet cli preview3 #1977

Conversation

forki commented Oct 24, 2016 • edited Loading

matthid left a comment

Choose a reason for hiding this comment

matthid Oct 24, 2016

Choose a reason for hiding this comment

forki Oct 25, 2016

Choose a reason for hiding this comment

matthid Oct 24, 2016

Choose a reason for hiding this comment

matthid Oct 24, 2016

Choose a reason for hiding this comment

forki Oct 25, 2016

Choose a reason for hiding this comment

forki commented Oct 25, 2016

theimowski commented Oct 25, 2016

forki commented Oct 25, 2016

theimowski commented Oct 25, 2016

forki commented Oct 25, 2016

theimowski commented Nov 1, 2016

forki commented Nov 1, 2016

theimowski commented Nov 1, 2016

theimowski commented Nov 3, 2016

forki commented Nov 3, 2016

forki commented Nov 3, 2016

enricosada commented Nov 3, 2016

enricosada commented Nov 3, 2016

forki commented Nov 3, 2016

theimowski commented Nov 3, 2016

forki commented Nov 3, 2016

theimowski commented Nov 3, 2016

forki commented Nov 3, 2016

theimowski commented Nov 3, 2016

enricosada commented Nov 3, 2016

forki commented Nov 3, 2016

theimowski commented Nov 3, 2016 • edited Loading

forki commented Nov 3, 2016

enricosada commented Nov 4, 2016 • edited Loading

forki commented Oct 24, 2016 •

edited

Loading

theimowski commented Nov 3, 2016 •

edited

Loading

enricosada commented Nov 4, 2016 •

edited

Loading