Ignore case in aliases dll names #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code was expecting the passed in name to be a lowercase substring of the dll file name. It's now expected to be the full name (not a substring) but allow the case to differ. Fixes fsprojects#1732
|
Oops binary files, i'll remove & rebase. |
|
Actually let's reopen this PR, I don't know what's the policy @forki The files are the same as the previous test so don't really take space in git, but I don't know why the files were present in the other one. To accelerate the tests ? to ensure that it's working if nuget remove the old versions ? (I have no problem changing the PR to not have them) |
|
they are there to keep things stable. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was expecting the passed in name to be a lowercase substring of the dll file name. It's now expected to be the full name (not a substring) but allow the case to differ.
Fixes #1732