Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias dll names must be specified as lower case #1732

Closed
vbfox opened this issue Jun 16, 2016 · 0 comments
Closed

Alias dll names must be specified as lower case #1732

vbfox opened this issue Jun 16, 2016 · 0 comments

Comments

@vbfox
Copy link
Contributor

vbfox commented Jun 16, 2016

Description

Contrary to what the documentation specifies library aliases dll names must be lowercase, it mean that the example in the documentation doesn't work.

The correct version being :

PackageA
  alias a1.dll Name2,Name3
  alias a2.dll MyAlias1
Dapper
NUnit

Repro steps

  1. Apply what the documentation specifies :

    PackageA
     alias A1.dll Name2,Name3
     alias A2.dll MyAlias1
    Dapper
    NUnit
    
  2. Run paket install

Expected behavior

Aliases are created when the exact dll name is specified.

Actual behavior

Doesn't create aliases in the project file.

Known workarounds

Please provide a description of any known workarounds.

Bla bla

Ideally the case would be completely ignored.

Also the current code matches on substrings & that might be a litle bit surprising (alias c foo will alias any dll containing the letter c)

ProjectFile.cs :

                    let l = lib.ToLower()
                    let aliases =
                        aliases
                        |> Seq.tryFind (fun kv -> l.Contains(kv.Key))
                        |> Option.map (fun kv -> kv.Value)

i'll send a PR with a fix

vbfox added a commit to vbfox/Paket that referenced this issue Jun 16, 2016
The previous code was expecting the passed in name to be a lowercase
substring of the dll file name. It's now expected to be the full name (not
a substring) but allow the case to differ.

Fixes fsprojects#1732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant