include symbols and src from referenced projects #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pms1969
commented
Jan 11, 2016
pms1969
commented
- include source files for referenced projects in symbols nupkg's
- ensure pdb's for referenced projects are included in nupkg's
- add command line option for pack (include-referenced-projects)
- create some tests for some of the above
* include source files for referenced projects in symbols nupkg's * ensure pdb's for referenced projects are included in nupkg's * add command line option for pack (include-referenced-projects) * create some tests for some of the above
| paths.[0] |> shouldEqual "..\\..\\src\\Paket\\Paket.fsproj" | ||
| paths.[1] |> shouldEqual "..\\Paket.Core\\Paket.Core.fsproj" | ||
| paths.[0] |> shouldEqual "..\\..\\..\\..\\src\\Paket\\Paket.fsproj" | ||
| paths.[1] |> shouldEqual "..\\..\\..\\..\\src\\Paket.Core\\Paket.Core.fsproj" |
There was a problem hiding this comment.
The unit tests used it. From where it is called by nunit, those projects do not exist in the paths that were specified.
|
cool |
forki
added a commit
that referenced
this pull request
Jan 11, 2016
include symbols and src from referenced projects
|
Sorry had to revert. Something is wrong with the paths. When I try to release, then Paket can't pack itself anymore. Please resubmit the PR and try to run "build.cmd NuGet" on the repo. |
|
ok, Probably be tomorrow now. I'll see what the problem is and fix. |
|
Thanks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.