Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket pack for symbols packages should allow for pulling in referenced projects. #1345

Closed
pms1969 opened this issue Jan 5, 2016 · 8 comments

Comments

@pms1969
Copy link
Contributor

pms1969 commented Jan 5, 2016

If I call "nuget pack -includereferencedprojects" when packaging sources, I get the referenced project source in the nupkg file. There doesn't seem to be like operator in Paket. Am I missing something?

Cheers,
Paul

@pms1969
Copy link
Contributor Author

pms1969 commented Jan 5, 2016

additonally, the pdb's are not currently packaged in the symbols package

@pms1969
Copy link
Contributor Author

pms1969 commented Jan 7, 2016

Can anyone give me a nudge in the right direction to fix this? I've found NupkgWriter, and would have thought it was in there somewhere, but nothing jumps out at me.

@baronfel
Copy link
Contributor

baronfel commented Jan 7, 2016

I've been looking for some documentation from nuget about what this flag does specifically, but have had no luck. Do you have any pointers? By 'referenced project source', you mean the actual source code, not pdbs or anything?

@pms1969
Copy link
Contributor Author

pms1969 commented Jan 7, 2016

Don't have any doco, but when we set it, it pulls in the source code from any referenced project as well as all the pdbs of referenced projects.

So if you had project A depending on project B, and packaged against project A, B's source and pdb would be available in the symbols package, as well as A's. The behaviour of paket (as far as I can see), is to only include the source and pdb from A.

The source is also added under it's project name, even if there are no reference projects (in nuget). This is not the case currently with paket.

@pms1969
Copy link
Contributor Author

pms1969 commented Jan 9, 2016

I have a working implementation of this, just need to add some tests to it and then I'll put in a pull request. Should be with you Monday some time.

@pms1969
Copy link
Contributor Author

pms1969 commented Jan 11, 2016

Pull Request submitted. Let me know what you think.

#1373

@pms1969
Copy link
Contributor Author

pms1969 commented Jan 13, 2016

resubmitted as #1383

@pms1969
Copy link
Contributor Author

pms1969 commented Jan 18, 2016

all done

@pms1969 pms1969 closed this as completed Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants