Handle .Net 4.5.2 projects

[Ravadre]

When I have a project which targets .net 4.5.2 and downloaded package has lib version of 4.5, Paket does not add references to that project. packet.references file is created in project directory correctly. I tried converting from nuget and then paket install --force as well as paket restore.

After inspecting changes to *.csproj I can see that Paket recognized and added guards for 4.5 and 4.5.1 versions correctly (4.5.1 is referencing path to 4.5 inside nuget package), but not for 4.5.2. Is creating 3rd When block for 4.5.2 an ok solution?

[agross]

Is there a lib/net452 folder in the nuget?

[Ravadre]

@agross No, but there's no 451 neither and 4.5.1 guards are added. I'm just watching paket source and I can see that 4.5.2 is just not yet handled I guess. (https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/FrameworkHandling.fs#L42-L43).

I wonder what is proper behavior here? Ignore if no net452 is present or link to net45? I think it should be consistent with 4.5.1 behavior?

[agross]

Yeah, you're probably the first one to target 4.5.2, so we never thought about supporting it in the first place.

I was just asking because it could have been that there's a special lib for 4.5.2. Documentation on allowed framework versions is a bit sparse. But I guess we should handle lib/net452 just like we did with lib/net451. I.e. lib/net4xxx should be installed for 4.5.2 as well.

[forki]

It should inherit from 4.5.1. - it's an easy fix. If no one finds it
tonight I will do it tomorrow.
On Oct 14, 2014 11:14 PM, "Marcin Deptuła" [email protected] wrote:

@agross https://github.com/agross No, but there's no 451 neither and
4.5.1 guards are added. I'm just watching paket source and I can see that
4.5.2 is just not yet handled I guess. (
https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/FrameworkHandling.fs#L42-L43
).

I wonder what is proper behavior here? Ignore if no net452 is present or
link to net45? I think it should be consistent with 4.5.1 behavior?

—
Reply to this email directly or view it on GitHub
#260 (comment).