Skip to content

Commit

Permalink
Paket handles .NET 4.5.2 and .NET 4.5.3 projects - fixes #260
Browse files Browse the repository at this point in the history
  • Loading branch information
forki committed Oct 15, 2014
1 parent 055275b commit 89287f9
Show file tree
Hide file tree
Showing 6 changed files with 98 additions and 4 deletions.
3 changes: 3 additions & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
#### 0.7.2 - 15.10.2014
* Paket handles .NET 4.5.2 and .NET 4.5.3 projects - https://github.com/fsprojects/Paket/issues/260

#### 0.7.1 - 14.10.2014
* New command: `paket update nuget <package id>` - http://fsprojects.github.io/Paket/paket-update.html#Updating-a-single-package

Expand Down
8 changes: 7 additions & 1 deletion src/Paket.Core/FrameworkHandling.fs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ type FrameworkVersionNo =
| V4
| V4_5
| V4_5_1
| V4_5_2
| V4_5_3
override this.ToString() =
match this with
| V1 -> "v1.0"
Expand All @@ -26,6 +28,8 @@ type FrameworkVersionNo =
| V4 -> "v4.0"
| V4_5 -> "v4.5"
| V4_5_1 -> "v4.5.1"
| V4_5_2 -> "v4.5.2"
| V4_5_3 -> "v4.5.3"

/// The Framework version.
type FrameworkVersion =
Expand All @@ -40,7 +44,9 @@ type FrameworkVersion =
FrameworkVersionNo.V4, Client
FrameworkVersionNo.V4, Full
FrameworkVersionNo.V4_5, Full
FrameworkVersionNo.V4_5_1, Full ]
FrameworkVersionNo.V4_5_1, Full
FrameworkVersionNo.V4_5_2, Full
FrameworkVersionNo.V4_5_3, Full ]

type PlatformVersion = string

Expand Down
4 changes: 2 additions & 2 deletions src/Paket/Paket.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
<DefineConstants>TRACE</DefineConstants>
<WarningLevel>3</WarningLevel>
<DocumentationFile>..\..\bin\Paket.xml</DocumentationFile>
<StartArguments>update nuget fake</StartArguments>
<StartWorkingDirectory>D:\code\PaketKopie</StartWorkingDirectory>
<StartArguments>update</StartArguments>
<StartWorkingDirectory>D:\code\Paket</StartWorkingDirectory>
</PropertyGroup>
<PropertyGroup>
<MinimumVisualStudioVersion Condition="'$(MinimumVisualStudioVersion)' == ''">11</MinimumVisualStudioVersion>
Expand Down
19 changes: 18 additions & 1 deletion tests/Paket.Tests/InstallModel/Xml/Fantomas.fs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
open Paket
open NUnit.Framework
open FsUnit
open System.Xml
open Paket.TestHelpers

let expected = """
Expand Down Expand Up @@ -80,6 +79,24 @@ let expected = """
</Reference>
</ItemGroup>
</When>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.5.2'">
<ItemGroup>
<Reference Include="FantomasLib">
<HintPath>..\..\..\Fantomas\lib\FantomasLib.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.5.3'">
<ItemGroup>
<Reference Include="FantomasLib">
<HintPath>..\..\..\Fantomas\lib\FantomasLib.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
</Choose>"""

[<Test>]
Expand Down
28 changes: 28 additions & 0 deletions tests/Paket.Tests/InstallModel/Xml/SystemNetHttp.fs
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,34 @@ let expected = """
</Reference>
</ItemGroup>
</When>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.5.2'">
<ItemGroup>
<Reference Include="System.Net.Http.Extensions">
<HintPath>..\..\..\Microsoft.Net.Http\lib\net45\System.Net.Http.Extensions.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
<Reference Include="System.Net.Http.Primitives">
<HintPath>..\..\..\Microsoft.Net.Http\lib\net45\System.Net.Http.Primitives.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.5.3'">
<ItemGroup>
<Reference Include="System.Net.Http.Extensions">
<HintPath>..\..\..\Microsoft.Net.Http\lib\net45\System.Net.Http.Extensions.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
<Reference Include="System.Net.Http.Primitives">
<HintPath>..\..\..\Microsoft.Net.Http\lib\net45\System.Net.Http.Primitives.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
<When Condition="$(TargetFrameworkIdentifier) == '.NETPortable' And $(TargetFrameworkProfile) == 'Profile88' And $(TargetPlatformIdentifier) == 'Portable' And $(TargetPlatformVersion) == '7.0'">
<ItemGroup>
<Reference Include="System.Net.Http.Extensions">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,46 @@ let expected = """
</Reference>
</ItemGroup>
</When>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.5.2'">
<ItemGroup>
<Reference Include="System.Net.Http.Extensions">
<HintPath>..\..\..\Microsoft.Net.Http\lib\net45\System.Net.Http.Extensions.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
<Reference Include="System.Net.Http.Primitives">
<HintPath>..\..\..\Microsoft.Net.Http\lib\net45\System.Net.Http.Primitives.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
<Reference Include="System.Net.Http">
<Paket>True</Paket>
</Reference>
<Reference Include="System.Net.Http.WebRequest">
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.5.3'">
<ItemGroup>
<Reference Include="System.Net.Http.Extensions">
<HintPath>..\..\..\Microsoft.Net.Http\lib\net45\System.Net.Http.Extensions.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
<Reference Include="System.Net.Http.Primitives">
<HintPath>..\..\..\Microsoft.Net.Http\lib\net45\System.Net.Http.Primitives.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
<Reference Include="System.Net.Http">
<Paket>True</Paket>
</Reference>
<Reference Include="System.Net.Http.WebRequest">
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
</Choose>"""

[<Test>]
Expand Down

0 comments on commit 89287f9

Please sign in to comment.