-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos / tweaks #125
Typos / tweaks #125
Conversation
The removal of the
|
Thanks for this and for fixing the typos. Those helpers are not used, because they are part of the surface area (i.e., the exposed functions). They should have tests attached to them, probably. We are not bound to the backwards and binary compat issues that F# needs to abide by, so maybe we should just use the "safe version" that's mentioned in your linked issue. Also, I'm aware of |
I could repurpose this PR by:
I'd propose to leave the AwaitTaskCorrect as private as egregious use of this nuget to patch stuff is not going to end well for anyone I have some concerns about Task/Async.map - it's presence rarely does good things for code IME even though I know lots of people want it, and it logically fits in with a certain style - would be happy to move it to the test module... Regarding AggregateException, if you have time, I have a puzzler I posed in https://discord.com/channels/196693847965696000/196695876054286336/1051212510675607552 - unfortunately I don't understand it well enough / havent worked hard enough to distil the problem down as yet to identify where it's coming from/being introduced (e.g. it could be doubly nested coming from the AWS SDK and two layers of AwaitTaskCorrect Flattening transitions might have been neutralising that) |
I see your point. I kinda figured these were nice to have standard functions. Maybe I should remove all the But let's take this discussion separate from this PR. Currently there isn't a single lib that has a bunch of these helper functions around, each lib comes with some of their own (fstoolkit, F#+, FusionTasks, AsyncEx), or none. Me adding to that forest of confusion is probably not a good thing. Maybe I should just collect all the useful helpers and create them as a separate lib, and internalize them here as private. |
OK, force pushed shaving off the commits re renamespacing and removal of AwaitTask-dependent stuff, so this is ready for merging and/or review (let me know if you want me to re-add the renamspacing of .Test -> .Tests) |
I'd dearly love to see an NOTE that working around/shimming some I guess that issue is probably the place to have the full discussion. |
I've rebased this. The remaining changes here are still useful, let's get them in. Tx for the cleanup! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll make one small change and will merge. The big change suggestion will go in a new PR.
Thanks for finding and fixing all my spelling errors, and improving the language! |
Async.AwaitTask