-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Productize Task/ValueTask/Async.ignore
#128
Comments
/cc @dsyme, we should discuss this. Some of this effort may ultimately land back into F# Core, but agreeing on a This is related to #78, specifically #78 (comment). |
Yeah I have a lot of the same functions floating around in IcedTasks (example1, example2) and FsToolkit (example1, example2) I even have a tool that writes out all the functions (like map, bind, apply, zip, etc) and which libraries contain them because it's hard to know who implementing what these days and where the gaps are in functionality. |
Switching close reason; work is not completed; sorry! |
Thanks for writing out these covering issues! Much appreciated! |
I've long felt icky about using
Async.Ignore
. Seeing theAsync.ignore
that's presently hiding in plain sight here makes me realise the absence of aTask.ignore
andValueTask.ignore
from FSharp.Core is something I've also been grinning and bearing (sprinkling:> Task
and all sorts of other such mindless hacks).Utils.fs
presently has helpers that feel very tempting to use more broadly. However, binding to a set of support helpers on the fringe of this library's core feature set is obviously debatable.(The other pair from here that I feel deserves a canonical implementation in a library that doesn't include a jungle of other less-related helpers is
Async.ofTask
/Task.toAsync
, but with correctedAggregateException
semantics, and honoring ofAsync.Cancellation
when compared toAsync.AwaitTask
as perFSharp.Core
. Will likely calve off a separate issue from this if placeholderFSharp.Core.TaskShims
package/repo is deemed to be the best home for a set ofignore
helpers)related:
AwaitTaskCorrect
to FSharp.Core suggestionThe text was updated successfully, but these errors were encountered: