Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ProcessHelper.ensureProcessesHaveStopped (#389) #412

Merged
merged 2 commits into from
Apr 25, 2014
Merged

Fixed ProcessHelper.ensureProcessesHaveStopped (#389) #412

merged 2 commits into from
Apr 25, 2014

Conversation

palpha
Copy link
Contributor

@palpha palpha commented Apr 25, 2014

Seq.isEmpty instead of comparison with Seq.empty.

@forki
Copy link
Member

forki commented Apr 25, 2014

I'll merge this, but what's the difference?

forki added a commit that referenced this pull request Apr 25, 2014
@forki
Merge pull request #412 from palpha/master
830a908 
Fixed ProcessHelper.ensureProcessesHaveStopped (#389)
@forki forki merged commit 830a908 into fsprojects:master Apr 25, 2014
@mexx
Copy link
Member

mexx commented Apr 26, 2014

@forki Process.GetProcesses() returns Process[] and it's not a Seq.empty, a comparision with [||] would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palpha @forki @mexx