Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProcessHelper.ensureProcessesHaveStopped does not work #389

Closed
palpha opened this issue Apr 3, 2014 · 4 comments
Closed

ProcessHelper.ensureProcessesHaveStopped does not work #389

palpha opened this issue Apr 3, 2014 · 4 comments

Comments

@palpha
Copy link
Contributor

palpha commented Apr 3, 2014

Either I'm doing it wrong, or it doesn't work as advertised :).

Limited testing suggests that it's the comparison with Seq.empty that fails (https://github.com/fsharp/FAKE/blob/4e7c28ab623865304dc83b0d5cefd7cb21f82bcd/src/app/FakeLib/ProcessHelper.fs#L453).
@forki
Copy link
Member

forki commented Apr 3, 2014

Can you please send me a pull request?

@palpha
Copy link
Contributor Author

palpha commented Apr 3, 2014

Will do!
On Apr 3, 2014 11:49 AM, "Steffen Forkmann" [email protected]
wrote:

Can you please send me a pull request?

Reply to this email directly or view it on GitHubhttps://github.com//issues/389#issuecomment-39433037
.

@forki
Copy link
Member

forki commented Apr 23, 2014

did you fix it?

@palpha
Copy link
Contributor Author

palpha commented Apr 25, 2014

At it now. Things got in the way, sorry.

palpha added a commit to palpha/FAKE that referenced this issue Apr 25, 2014
@palpha
Fixed ProcessHelper.ensureProcessesHaveStopped (fsprojects#389)
b1e7fef
forki added a commit that referenced this issue Apr 25, 2014
@forki
Merge pull request #412 from palpha/master
830a908 
Fixed ProcessHelper.ensureProcessesHaveStopped (#389)
@forki forki closed this as completed Apr 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forki @palpha