-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for publish profiles #2366
Add support for publish profiles #2366
Conversation
The build failure appears to be not related to my changes. |
Thanks for taking care of this! As this is basically a breaking change we need to think about how we want to handle it...We can:
|
To remove the breaking change I would have to use nullable types instead of option, but this is not best idea in F# I think. |
There has not been any activity in this pull request for the last 3 months so it will be closed in 14 days if there is no activity. |
Sorry for such long break. I want to make a new module SqlPackage and put there my changes, leaving old DacPac module without change. @matthid would be better to revert these commits and make change here in this PR, or maybe create new branch and new PR? |
@kmadof Sure just push ahead or create a new PR whatever you prefer. |
@matthid can we remove stale label to be sure that PR won't be closed. |
@matthid can you help me find out what I did wrong? I really don't understand how my changes impacted DotNet Core Integration tests. |
@kmadof They didn't, I guess we need to update paket due to fsprojects/Paket#3743. I'll try to get the |
@matthid did you have time to fix release/next? |
Yes, only travis is still doing something weird but it is quite tricky to debug as it happens only on travis |
@matthid I see that now all checks passed. Cool. Thanks for that. What's next? |
Sorry for the late review, I asked two small questions and I think one small thing is missing. You added a new documentation file ( Otherwise, the approach looks good to me. |
Description
I added support for publish profile file. I changed the way how we set default values for deployment arguments, because arguments given from command line override values from publish profile. So when publish profile is given we must set command lin only when they explicitly set, and not when they are not given like it was before. When publish profile is not given I set command line arguments like it was before.
If available, link to an existing issue this PR fixes. For example: