Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Pickles with Framework #1894 #1901

Merged
merged 3 commits into from
May 4, 2018
Merged

Run Pickles with Framework #1894 #1901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
573127f
Run Pickles with Framework #1894
magicmonty May 1, 2018
7d7d2ff
Removed Reference to .fake directory in Pickles doc
May 2, 2018
58dacef
Fix superfluous quote in Pickles documentation
May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions help/markdown/fake-tools-pickles.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@
#r "paket:
nuget Fake.Core.Target
nuget Fake.IO.FileSystem
nuget Fake.Tools.Pickles //"
nuget Fake.Tools.Pickles
//"

open Fake.Core
open Fake.Core.TargetOperators
open Fake.IO.FileSystemOperators
open Fake.IO.Globbing
open Fake.Tools
open System.IO

Expand Down
5 changes: 3 additions & 2 deletions src/app/Fake.Tools.Pickles/Pickles.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,9 @@ let convert setParams =
let makeProcessStartInfo info =
{ info with FileName = parameters.ToolPath
WorkingDirectory = "."
Arguments = parameters |> buildPicklesArgs }
Arguments = parameters |> buildPicklesArgs }
|> Process.withFramework

let result = Process.execSimple makeProcessStartInfo parameters.TimeOut
let result = Process.execSimple makeProcessStartInfo parameters.TimeOut

ResultHandling.failBuildIfPicklesReportedError parameters.ErrorLevel result