-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Pickles with Framework #1894 #1901
Conversation
help/markdown/fake-tools-pickles.md
Outdated
@@ -22,7 +24,8 @@ Target.create "BuildDoc" (fun _ -> | |||
Pickles.convert (fun p -> | |||
{ p with FeatureDirectory = currentDirectory </> "Specs" | |||
OutputDirectory = currentDirectory </> "SpecDocs" | |||
OutputFileFormat = Pickles.DocumentationFormat.DHTML }) | |||
OutputFileFormat = Pickles.DocumentationFormat.DHTML | |||
ToolPath = Tools.findToolInSubPath "pickles.exe" "~/.fake/build.fsx/packages" }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not something we should suggest. I consider the .fake
directory basically implementation detail. I can see the problem but I don't have a good solution. Maybe we can automatically search in the users .nuget
directory. This way it doesn't need to be copied in .fake
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthid Fine. Is there already a helper to get the .nuget directory of the user?
Because nearly all of my PR's (ReportGenerator, Pickles and SpecFlow) depend on a external NuGet package with the tool or the tool itself already installed.
I haven't found a different way yet. Maybe by setting the path in the Paket storage option explicitely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe by setting the path in the Paket storage option explicitely?
I don't think this is supported ;)
I haven't found a different way yet.
Yes this is currently a PIA, the only resolution currently is to not use inline-dependencies but use a paket.dependencies
file.
Is there already a helper to get the .nuget directory of the user?
Please just feel free to add one or create a similar helper to
Just for searching in nuget. The remaining question is how we handle multiple versions? Maybe we return a list of (version, tool-path) and let the user choose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way: This is how paket finds the .nuget/packages
folder:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthid Ok, I have a look then
@matthid I removed the "offending" part from the doc. I will make another PR for this eventually |
Yes that makes sense to me. Thanks! |
Add Process.withFramework for Fake.Tools.Pickles to ensure it runs not only in Windows
Updated Doc for a real working example