Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Pickles with Framework #1894 #1901

Merged
merged 3 commits into from
May 4, 2018
Merged

Conversation

magicmonty
Copy link
Contributor

Add Process.withFramework for Fake.Tools.Pickles to ensure it runs not only in Windows

Updated Doc for a real working example

@@ -22,7 +24,8 @@ Target.create "BuildDoc" (fun _ ->
Pickles.convert (fun p ->
{ p with FeatureDirectory = currentDirectory </> "Specs"
OutputDirectory = currentDirectory </> "SpecDocs"
OutputFileFormat = Pickles.DocumentationFormat.DHTML })
OutputFileFormat = Pickles.DocumentationFormat.DHTML
ToolPath = Tools.findToolInSubPath "pickles.exe" "~/.fake/build.fsx/packages" })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not something we should suggest. I consider the .fake directory basically implementation detail. I can see the problem but I don't have a good solution. Maybe we can automatically search in the users .nuget directory. This way it doesn't need to be copied in .fake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthid Fine. Is there already a helper to get the .nuget directory of the user?
Because nearly all of my PR's (ReportGenerator, Pickles and SpecFlow) depend on a external NuGet package with the tool or the tool itself already installed.
I haven't found a different way yet. Maybe by setting the path in the Paket storage option explicitely?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe by setting the path in the Paket storage option explicitely?

I don't think this is supported ;)

I haven't found a different way yet.

Yes this is currently a PIA, the only resolution currently is to not use inline-dependencies but use a paket.dependencies file.

Is there already a helper to get the .nuget directory of the user?

Please just feel free to add one or create a similar helper to

https://github.com/fsharp/FAKE/blob/2251ecc2343388dcc470dcc13b6babdeed72b151/src/app/Fake.Core.Process/Process.fs#L615

Just for searching in nuget. The remaining question is how we handle multiple versions? Maybe we return a list of (version, tool-path) and let the user choose?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthid Ok, I have a look then

@magicmonty magicmonty changed the title Run Pickles with Framework #1894 WIP: Run Pickles with Framework #1894 May 1, 2018
@magicmonty magicmonty changed the title WIP: Run Pickles with Framework #1894 Run Pickles with Framework #1894 May 2, 2018
@magicmonty
Copy link
Contributor Author

@matthid I removed the "offending" part from the doc. I will make another PR for this eventually

@matthid
Copy link
Member

matthid commented May 4, 2018

I removed the "offending" part from the doc. I will make another PR for this eventually

Yes that makes sense to me. Thanks!

@matthid matthid changed the base branch from master to rc_11 May 4, 2018 22:54
@matthid matthid merged commit 3665748 into fsprojects:rc_11 May 4, 2018
@matthid matthid mentioned this pull request May 6, 2018
@magicmonty magicmonty deleted the pickles branch October 9, 2018 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants