Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General FAKE improvements #1088

Merged
merged 15 commits into from
Jan 20, 2016
Merged

General FAKE improvements #1088

merged 15 commits into from
Jan 20, 2016

Conversation

matthid
Copy link
Member

@matthid matthid commented Jan 19, 2016

See #1083. Bah I hope its the last time now. This turned out to be way harder than imagined.

forki added a commit that referenced this pull request Jan 20, 2016
@forki forki merged commit 745a6c6 into fsprojects:master Jan 20, 2016
@forki
Copy link
Member

forki commented Jan 20, 2016

@bjartwolf can you please verify latest alpha works for you?

@bjartwolf
Copy link
Contributor

Testing now. Letting you know in a minute...

@bjartwolf
Copy link
Contributor

Works fine on TeamCity.

@forki
Copy link
Member

forki commented Jan 20, 2016

thx. starting proper release

@matthid
Copy link
Member Author

matthid commented Jan 20, 2016

Lets hope the best, thanks @forki for all the patience and sorry for breaking things several times (at least we now have more unit tests).

@forki
Copy link
Member

forki commented Jan 20, 2016

don't worry. I'm happy that you and other people care so much about the tool.

@forki
Copy link
Member

forki commented Jan 20, 2016

image

I updated FAKE in Paket and get this when running build on fsprojects/Paket@844dcb8

@forki
Copy link
Member

forki commented Jan 20, 2016

says it cannot load a type in the assembly

@matthid
Copy link
Member Author

matthid commented Jan 20, 2016

looking into it...

@matthid
Copy link
Member Author

matthid commented Jan 20, 2016

Sadly I cannot reproduce, tried to checkout the git hash and 'paket restore -f'. Does "-pd" give the full error message?

@forki
Copy link
Member

forki commented Jan 20, 2016

ok deleted .fake folder - seems to work now

@forki
Copy link
Member

forki commented Jan 20, 2016

I guess we should invalidate all caches. Can you submit a PR which does that? maybe we need a cache version encoded in the file name.

@matthid
Copy link
Member Author

matthid commented Jan 20, 2016

hm, maybe something to do with included scripts, but I thought we handle them in the caching code.... Could you send me the broken assembly (out of the recycle bin)?

@matthid
Copy link
Member Author

matthid commented Jan 20, 2016

Do you mean FAKE version?

@forki
Copy link
Member

forki commented Jan 20, 2016

In paket we have: https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/Nuget.fs#L25

whenever we change that property paket will not take older caches

@matthid
Copy link
Member Author

matthid commented Jan 20, 2016

Ah you mean a cache version, got it. For this particular change I added a warning file so it should have invalidated already...

@matthid
Copy link
Member Author

matthid commented Jan 20, 2016

Therefore I assume something else is to blame here.

@matthid
Copy link
Member Author

matthid commented Jan 20, 2016

I think it's better to print the exception, invalidate the cache and recompile if loading the cached assembly fails, this should work without adding any version. And it works in the case that something did go wrong when writing the cache (power outrage for example). I can come up with a PR if you agree (actually I wanted to include that but I decided to feature stop after it broke again and again :D ).

@forki
Copy link
Member

forki commented Jan 20, 2016

sounds good

@matthid
Copy link
Member Author

matthid commented Jan 20, 2016

By the way with this change we can finally move FAKE forwards in the sense that we can mark some ot the <AutoOpen> modules as obsolete if we want to (as people will finally see the warnings and have a opportunity to move away). Whats the status there, is this still on the wish list?

@matthid matthid deleted the fsharp_scripting branch June 16, 2017 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants