Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General FAKE improvements #1083

Merged
merged 13 commits into from
Jan 19, 2016
Merged

General FAKE improvements #1083

merged 13 commits into from
Jan 19, 2016

Conversation

matthid
Copy link
Member

@matthid matthid commented Jan 18, 2016

See #1080. Sorry for all the problems produced by this.

At least I can now use the cleaned-up commits. I attached tests and fixes for the found issues at the end.

@matthid
Copy link
Member Author

matthid commented Jan 18, 2016

I think there is still one minor glitch when scripts write to stderr

@matthid
Copy link
Member Author

matthid commented Jan 18, 2016

I don't think scripts currently write into stderr so it is not that critical, should we just let them?
On the other hand some build servers fail when we write to stderr and we could (and actually DO with this PR) handle that within FAKE by calling traceError but obviously this is not working when running the cached version. I think I'm adjusting this by redirecting stderr and stdout when calling the cached version as well.

@matthid
Copy link
Member Author

matthid commented Jan 18, 2016

Ok I think this should work now

@forki
Copy link
Member

forki commented Jan 19, 2016

Ok cool. Let's try again.

forki added a commit that referenced this pull request Jan 19, 2016
@forki forki merged commit e0bf214 into fsprojects:master Jan 19, 2016
forki added a commit that referenced this pull request Jan 19, 2016
This reverts commit e0bf214, reversing
changes made to 8ebc375.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants