Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

Updated to FsXaml 0.9.9 #808

Merged
merged 3 commits into from
Oct 30, 2014
Merged

Updated to FsXaml 0.9.9 #808

merged 3 commits into from
Oct 30, 2014

Conversation

ReedCopsey
Copy link
Contributor

Adjusted for new API changes in FsXaml.

Adjusted for new API changes in FsXaml.
@@ -11,7 +11,7 @@ open FSharp.ViewModule.Progress
open FSharp.ViewModule.Validation
open System.Threading

type RenameDialog = FsXaml.XAML<"RenameDialog.xaml">
type RenameDialog = FsXaml.XAML<"RenameDialog.xaml", true>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does 'true' mean in this context? Could you add the argument name so that the purpose is clear?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. It exposes the named properties in the XAML file as properties on the RenameDialog type.

@dungpa
Copy link
Contributor

dungpa commented Oct 30, 2014

Don't know why but I got this error when trying to open a dialog:

image

@ReedCopsey
Copy link
Contributor Author

Which dialog? It sounds like, for some reason, you've got mixed assembly
versions (ie: an old FsXaml core library but a new type provider, or
something), but I'd like to make sure it wasn't a problem on my end.

On Thu, Oct 30, 2014 at 3:40 PM, Anh-Dung Phan [email protected]
wrote:

Don't know why but I got this error when trying to open a dialog:

[image: image]
https://cloud.githubusercontent.com/assets/941060/4853415/a1c6756a-6085-11e4-9f56-8b8cb4ab8222.png


Reply to this email directly or view it on GitHub
#808 (comment)
.

@dungpa
Copy link
Contributor

dungpa commented Oct 30, 2014

I've got that error on all three dialogs.

Just double check versions of FsXaml.Wpf and FsXaml.Wpf.TypeProvider. They're both in 0.9.9.

@ReedCopsey
Copy link
Contributor Author

@dungpa I can't duplicate - I just did a full rebuild, and installed the release version, in case it was a debug/release issue - working perfectly here. Debugging worked for me to change and test, too. The only way that message makes sense is if it's loading 0.9.8 or earlier of the core library (FsXaml.Wpf) somehow. Any ideas of what might be different? I'm in VS 2013. (Just trying to think of anything different at all...)

@ReedCopsey
Copy link
Contributor Author

@dungpa I did notice that Paket is adding the references with Specific Version = false...not sure if that's having an impact /cc @forki

@dungpa
Copy link
Contributor

dungpa commented Oct 30, 2014

I ran F5 from the Debug configuration.

It's the issue with type provider caches. I have to uncheck all the cache items and recheck the exact location (it has changed several times due to Paket) and rebuild everything. Now it works fine. Sorry for the false alert.

dungpa added a commit that referenced this pull request Oct 30, 2014
@dungpa dungpa merged commit 9a770f1 into fsprojects-archive:master Oct 30, 2014
@ReedCopsey ReedCopsey deleted the fsxaml_update branch October 30, 2014 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants