WIP: Rename suggestion list for rename dialog

[forki]

This is WIP but I want to collect feedback from the beginning

[OkayX6]

Do you have ReSharper? You could try to mimick & guess their name suggestion behavior.

[forki]

Yep that's the plan. But we'll starting small and improve

[vasily-kirichenko]

How it's supposed to work? I thought there will be a drop-down list in Rename dialog.

[forki]

Yes there will be a suggestion list in rename dialog. I already asked Reed
I'd he can help. In this pull request I try to find out what kind of
suggestions could work.
On Jul 12, 2014 11:39 AM, "Vasily Kirichenko" [email protected]
wrote:

How it's supposed to work? I thought there will be a drop-down list in
Rename dialog.

—
Reply to this email directly or view it on GitHub
#579 (comment)
.

[forki]

I squashed all the commits since I accidentilly included some wrong dlls.

[forki]

this is now an observable, but it needs careful review.

/cc @tpetricek @ReedCopsey

[dungpa]

This PR is getting better and better.

@forki What's wrong with your Github account? I don't see you in the list of contributors in this project anymore.

[ReedCopsey]

@forki Just sent you a PR on your branch which does some cleanup of the UI - should make it easier to play around with, especially since up and down arrow and mouse let you use the suggestions now.

[forki]

@dungpa I changed my github mail address and had to add the original address as secondary mail. seems to work again

[forki]

@ReedCopsey I think I did the stuff we talked about.

[dungpa]

@forki: I have a few questions:

1. Is there any way to make the suggestion list smaller? Intellisense-like suggestion would be great; even a dropdown could help here.
2. What is the algorithm to create suggestions? How do you rank relevancy of these suggestions?
3. Do you plan to filter out suggestions? I think the list of suggestions is unnecessary long (for 3 or 4-word names). Imagine you have 10 suggestions for each word, then an 4-word name gets 10^4 suggestions.

[ReedCopsey]

@dungpa I can chime in here - since I've discussed this with @forki ...

Part of the problem is how the thesaurus works - it doesn't really give you a way to prioritize - you just get a list of suggestions with no idea of whether they're good or bad.

The current plan is to shrink the window so we only show the "manual" and spell check suggestions by default. A "Suggest more" button/option will pull up the thesaurus based suggestions (which is what makes the list huge).

I'm thinking that I'll have the window increase in size if you click "Suggest more".

We were going to switch to this since the thesaurus results are typically not that useful - but the others are far more relevant nearly 100% of the time. The last set of commits is leading the way to me being able to change the UI in that direction.

[dungpa]

Good idea. Spelling correction is often what you want. Thesaurus-based suggestion is nice to have. I would love to see filtering of thesaurus-based suggestions as well; the number of suggestions is simply too big.

[vasily-kirichenko]

Maybe make it intellisense-like and show a small number of suggestions initially. Than, if user scroll down the list to the end, we add some more items, and so on. It'd be like "endless page" that's used by google to show search images result.

[forki]

The thesaurus will be hidden behind a button. It produces some good terms
but also a lot of junk. Filtering is not really possible since we cannot
know the original meaning of a word. Thesaurus brings you synonyms for all
meanings of a word.
The only thing we can do is to take the top 3 for every meaning.

Another problem are camelHumpsIdentifiers. At the moment we try to suggest
synonyms for every part and then create the product of the terms. I will
change this so that only one part of the word is replaced with a synonym.
This will reduce this dramatically.
On Jul 18, 2014 8:14 AM, "Anh-Dung Phan" [email protected] wrote:

Good idea. Spelling correction is often what you want. Thesaurus-based
suggestion is nice to have. I would love to see filtering of
thesaurus-based suggestions as well; the number of suggestions is simply
too big.

—
Reply to this email directly or view it on GitHub
#579 (comment)
.

[ReedCopsey]

I'm not sure I agree about only doing on "part" of the camelHump - you'd never know which part should be suggested...

I think we should start with just hiding the thesaurus, and see how nice we can get it at that point. If it's still seems "bad", we can look into other options. We could maybe do the top 3 for each camelHumpSection, then have a "Show even more..." option to get the rest or something like that...?

[vasily-kirichenko]

@forki @dungpa So what's the status of this? Let's merge it or what?

[dungpa]

It's not ready yet. The UI part is still missing.

[forki]

@ReedCopsey how can we proceed?

[ReedCopsey]

@forki Once #808 is merged, can you get the current conflicts cleaned up? If so, I'll try to add the UI bits so this can be merged as well.

[forki]

I rebased it

[vasily-kirichenko]

We should finally do something with it :)

[dungpa]

The PR has been here for too long. I don't think we have resources to revive it. Closing.