-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experimental] Rename FCS to avoid clashes (for #1096) #1097
Conversation
I added test script, which checks that another version of FCS can be loaded, but that's not actually run anywhere yet - so if we want to do this change, I'll need to turn this into a proper test first :) |
'packages\Mono.Cecil\lib\net45\Mono.Cecil.dll' missing Seems you forgot to commit the deps and lock file |
I fixed the paths and Travis now reports one failure (still working on AppVeyor):
Do you have any hints on what this might mean? Is there some easy way of running the FAKE tests with a debugger attached? |
Visual Studio works for me :)
Error is here https://travis-ci.org/fsharp/FAKE/builds/103908100#L2181 But no I have no idea whats going on |
It looks like FCS is searching for itself somehow? The script in the test is simply referencing |
As far as I can see:
I tried searching F.C.S source code for places where it might try to reference itself using assembly name, but did not find anything. Though if we can get confirmation from @dsyme, that would help :) |
Let's try to build a new alpha |
[Experimental] Rename FCS to avoid clashes (for #1096)
I take that back. release failed because missing Fake.FSharp.Compiler.Service.dll.XML during docs build in FSharp.Formmating ;-) |
ok fixed that. let's see |
oK release succeeded. let's start dogfooding in FAKE and Paket. |
ok seems to work in Paket and FAKE itself |
This implements the solution (3) for #1096