Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make zero Fuse value usable #1

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Make zero Fuse value usable #1

merged 3 commits into from
Feb 26, 2024

Commits on Feb 26, 2024

  1. Fix throttle test.

    @dennwc
    dennwc committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    fe34aec View commit details
    Browse the repository at this point in the history

  2. Breaking change: Make zero Fuse value usable. 

    Zero value of synchronisation primitives like sync.Mutex and sync.WaitGroup are valid. One may expect similar behavior from Fuse, where it can be added as a struct field and used without additional initialization.

This change makes Fuse a struct and updates the logic to allow using zero values. Unfortunately due to the change from interface to struct, the change is breaking (requires to remove the constructor).
    @dennwc
    dennwc committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    85a1b34 View commit details
    Browse the repository at this point in the history

  3. Add Fuse test. Fix data races in other tests. Enable CI.

    @dennwc
    dennwc committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    0311f13 View commit details
    Browse the repository at this point in the history