Make zero Fuse value usable #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zero value of synchronisation primitives like sync.Mutex and sync.WaitGroup are valid. One may expect similar behavior from Fuse, where it can be added as a struct field and used without additional initialization. This change makes Fuse a struct and updates the logic to allow using zero values. Unfortunately due to the change from interface to struct, the change is breaking (requires to remove the constructor).
frostbyte73
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero value of standard synchronization primitives like
sync.Mutexandsync.WaitGroupare valid. One may expect similar behavior fromcore.Fuse, where it can be added as a struct field and used without additional initialization.This change makes
Fusea struct and updates the logic to allow using zero values. Unfortunately due to the change from interface to struct, the change is breaking (requires to remove the constructor or field type).