-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance/ember 2.15 #5
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,4 +14,8 @@ | |
/coverage/* | ||
/libpeerconnection.log | ||
npm-debug.log* | ||
yarn-error.log | ||
testem.log | ||
|
||
# editors | ||
jsconfig.json |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,8 +9,8 @@ | |
|
||
{{content-for "head"}} | ||
|
||
<link rel="stylesheet" href="{{rootURL}}assets/vendor.css"> | ||
<link rel="stylesheet" href="{{rootURL}}assets/frolfr-web.css"> | ||
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this is needed for the ember-sri addon (SubResource Integrity). See https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity |
||
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/frolfr-web.css"> | ||
|
||
{{content-for "head-footer"}} | ||
</head> | ||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
/* eslint-env node */ | ||
|
||
module.exports = function(environment) { | ||
var ENV = { | ||
let ENV = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
apiHost: '', | ||
modulePrefix: 'frolfr-web', | ||
environment: environment, | ||
environment, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
rootURL: '/', | ||
locationType: 'auto', | ||
EmberENV: { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
/* eslint-env node */ | ||
module.exports = { | ||
browsers: [ | ||
'ie 9', | ||
'last 1 Chrome versions', | ||
'last 1 Firefox versions', | ||
'last 1 Safari versions' | ||
] | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,19 @@ | ||
/* eslint-env node */ | ||
module.exports = { | ||
"test_page": "tests/index.html?hidepassed", | ||
"disable_watching": true, | ||
"launch_in_ci": [ | ||
"PhantomJS" | ||
test_page: 'tests/index.html?hidepassed', | ||
disable_watching: true, | ||
launch_in_ci: [ | ||
'Chrome' | ||
], | ||
"launch_in_dev": [ | ||
"PhantomJS", | ||
"Chrome" | ||
] | ||
launch_in_dev: [ | ||
'Chrome' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no more Phantom - 2.15 defaults to headless Chrome for all tests. See the release blog post for deets |
||
], | ||
browser_args: { | ||
Chrome: [ | ||
'--disable-gpu', | ||
'--headless', | ||
'--remote-debugging-port=9222', | ||
'--window-size=1440,900' | ||
] | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this go away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it's no longer needed. emberjs/ember.js#15204