-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance/ember 2.15 #5
Conversation
"Chrome" | ||
] | ||
launch_in_dev: [ | ||
'Chrome' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no more Phantom - 2.15 defaults to headless Chrome for all tests. See the release blog post for deets
@@ -3,11 +3,7 @@ import Resolver from './resolver'; | |||
import loadInitializers from 'ember-load-initializers'; | |||
import config from './config/environment'; | |||
|
|||
let App; | |||
|
|||
Ember.MODEL_FACTORY_INJECTIONS = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this go away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it's no longer needed. emberjs/ember.js#15204
@@ -9,8 +9,8 @@ | |||
|
|||
{{content-for "head"}} | |||
|
|||
<link rel="stylesheet" href="{{rootURL}}assets/vendor.css"> | |||
<link rel="stylesheet" href="{{rootURL}}assets/frolfr-web.css"> | |||
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is needed for the ember-sri addon (SubResource Integrity). See https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity
@@ -1,10 +1,10 @@ | |||
/* eslint-env node */ | |||
|
|||
module.exports = function(environment) { | |||
var ENV = { | |||
let ENV = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
apiHost: '', | ||
modulePrefix: 'frolfr-web', | ||
environment: environment, | ||
environment, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to get some feedback on the couple of questions I asked. Otherwise this looks bueno! I guess I should probably look into upgrading at work too... 😄
Did you do that manually, or use |
I manually do it. |
Upgrades us to all things 2.15 (ember-cli, ember, ember-data).
I use version diffs from the ember-cli/ember-new-output repo for upgrades