Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance/ember 2.15 #5

Merged
merged 2 commits into from
Sep 10, 2017
Merged

Maintenance/ember 2.15 #5

merged 2 commits into from
Sep 10, 2017

Conversation

ultimatemonty
Copy link
Member

@ultimatemonty ultimatemonty commented Sep 4, 2017

Upgrades us to all things 2.15 (ember-cli, ember, ember-data).

I use version diffs from the ember-cli/ember-new-output repo for upgrades

"Chrome"
]
launch_in_dev: [
'Chrome'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more Phantom - 2.15 defaults to headless Chrome for all tests. See the release blog post for deets

@@ -3,11 +3,7 @@ import Resolver from './resolver';
import loadInitializers from 'ember-load-initializers';
import config from './config/environment';

let App;

Ember.MODEL_FACTORY_INJECTIONS = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this go away?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it's no longer needed. emberjs/ember.js#15204

@@ -9,8 +9,8 @@

{{content-for "head"}}

<link rel="stylesheet" href="{{rootURL}}assets/vendor.css">
<link rel="stylesheet" href="{{rootURL}}assets/frolfr-web.css">
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is needed for the ember-sri addon (SubResource Integrity). See https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity

@@ -1,10 +1,10 @@
/* eslint-env node */

module.exports = function(environment) {
var ENV = {
let ENV = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

apiHost: '',
modulePrefix: 'frolfr-web',
environment: environment,
environment,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@gschorkopf gschorkopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to get some feedback on the couple of questions I asked. Otherwise this looks bueno! I guess I should probably look into upgrading at work too... 😄

@gschorkopf
Copy link
Member

I use version diffs from the ember-cli/ember-new-output repo for upgrades

Did you do that manually, or use ember init?

@ultimatemonty
Copy link
Member Author

I manually do it. ember init tends to wipe out some changes. Some folks will ember init and then look at the diffs for each file that changed. I prefer to just do it manually via the diffs from the ember-new-output project.

@gschorkopf gschorkopf merged commit 7bd6a97 into master Sep 10, 2017
@gschorkopf gschorkopf deleted the maintenance/ember-2.15 branch September 10, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants