Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use update_log instead of sys.stdout for consistent log order #59

Merged
merged 3 commits into from
Aug 6, 2021

Conversation

samipfjo
Copy link
Contributor

@samipfjo samipfjo commented Aug 5, 2021

No description provided.

@friggog
Copy link
Owner

friggog commented Aug 6, 2021

Why is

update_log = parametric.gen.update_log

Not
from .parametric.gen import update_log
also absolute imports might be preferable to relative ones?

@friggog friggog merged commit c4d0a57 into friggog:master Aug 6, 2021
@samipfjo
Copy link
Contributor Author

samipfjo commented Aug 6, 2021

Hmm, not sure. Fixed now.

A while back you switched all the imports to relative, so the from .parametric.gen import update_log you proposed is consistent with the existing formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants