Support http2 keep-alive #90
Conversation
github-actions
bot
added
part:tests
shsms
dismissed stale reviews from llucax and Marenz
Dismissing because the red colour is super unplesant.
🤣 I wish we used it more actually, I try not to use it because I agree if feels a bit aggressive, but it is very useful to indicate some comments really need to be addressed vs. just adding optional comments. In this case I just used it to avoid a merge at least until we discuss the comments as the PR was already approved, but didn't think of just dismissing the approval, that would have been another option 👍 |
There was a problem hiding this comment.
Only a couple of minor things: I think is important to mention keep-alive is enabled by default now in the release notes, but I'm OK with merging without making max_pings_without_data and keepalive_permit_without_calls for now, just curious about the reasons not to do it.
RELEASE_NOTES.md
Outdated
There was a problem hiding this comment.
I would also add a note to Upgrading that now keep-alive is enabled by the default options and that the default configuration should probably be tuned according to the client requirements.
`defaults.ssl.enabled` is a bool, it will never be `None`. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
Co-authored-by: daniel-zullo-frequenz <[email protected]> Signed-off-by: Sahas Subramanian <[email protected]>
daniel-zullo-frequenz
removed this pull request from the merge queue due to a manual request
|
I remove it from the queue in case you want to check/fix a typo. And probably you also want to wait for Luca's approval |
No description provided.