Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring keepalive and use a reasonable default value #68

Closed
llucax opened this issue Aug 13, 2024 · 1 comment · Fixed by #90
Closed

Allow configuring keepalive and use a reasonable default value #68

llucax opened this issue Aug 13, 2024 · 1 comment · Fixed by #90
Assignees
Labels
part:code Affects the code in general priority:high Address this as soon as possible type:bug Something isn't working
Milestone

Comments

@llucax
Copy link
Contributor

llucax commented Aug 13, 2024

What happened?

When a connection is idle, and the networking drops (or the server disappears without properly disconnecting), the client happily waits forever on active stream, but no data will ever come again, at least for a long time if TCP keepalive kicks in.

What did you expect instead?

We should configure the gRPC channel keepalive feature to have some reasonable default, and to be able to override the defaults via the connection URL. We should also check if some default keepalive is already configured in gRPC.

Affected version(s)

No response

Affected part(s)

Code (part:code)

Extra information

Coming from:

@llucax llucax added priority:❓ We need to figure out how soon this should be addressed type:bug Something isn't working labels Aug 13, 2024
@keywordlabeler keywordlabeler bot added the part:code Affects the code in general label Aug 13, 2024
@llucax llucax added priority:high Address this as soon as possible and removed priority:❓ We need to figure out how soon this should be addressed labels Aug 13, 2024
@llucax llucax added this to the v0.6.0 milestone Aug 13, 2024
@llucax llucax changed the title Allow configuring keepalive and use a resable default value Allow configuring keepalive and use a reasonable default value Aug 20, 2024
@llucax llucax modified the milestones: v0.6.0, v0.7.0 Aug 20, 2024
@llucax llucax self-assigned this Sep 10, 2024
@llucax llucax modified the milestones: v0.7.0, v0.8.0 Oct 29, 2024
@llucax
Copy link
Contributor Author

llucax commented Oct 30, 2024

Done via:

@llucax llucax closed this as completed Oct 30, 2024
@llucax llucax linked a pull request Oct 30, 2024 that will close this issue
@llucax llucax assigned shsms and unassigned llucax Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:code Affects the code in general priority:high Address this as soon as possible type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants