Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: swap in Footer component from @frequency-chain/style-guide #43

Conversation

JoeCap08055
Copy link
Contributor

Screenshot(s)

Desktop:
image

Mobile/small screen:
image

Please delete options that are not relevant.

  • Content Change (Required approval in Slack: #frequency-xyz and remember that changes along the way trigger
    re-approval.)
    • Approved HE (Required for technical wording)
    • Approved CM
    • Approved UO

How to Test?

  1. Pull branch
  2. Run npm run dev -- --open
  3. Visually verify that the footer matches the screenshots

Checklist:

  • I have performed a self-review of my code
  • I have commented my code & PR, particularly in hard-to-understand areas
  • I have checked at all the breakpoints to make sure it works on all screen sizes

Copy link
Contributor

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Creating a follow up issue to add the extends and content additions in the readme of the styleguide. Ready to go once the checks are passing!

Copy link
Contributor

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

- also fix tailwindow.config.js to use 'extend' property, else Tailwind classes from the package don't come through always
@JoeCap08055 JoeCap08055 force-pushed the 36-update-the-footer-with-the-one-from-the-style-guide branch from 2d901ce to cbf1acc Compare October 30, 2024 14:29
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/43/
Commit: cb89025

@JoeCap08055 JoeCap08055 merged commit bc23068 into developer-portal Oct 30, 2024
5 checks passed
@JoeCap08055 JoeCap08055 deleted the 36-update-the-footer-with-the-one-from-the-style-guide branch October 30, 2024 14:31
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants