Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the footer with the one from the style guide #36

Closed
Tracked by #22
wilwade opened this issue Oct 28, 2024 · 1 comment
Closed
Tracked by #22

Update the footer with the one from the style guide #36

wilwade opened this issue Oct 28, 2024 · 1 comment
Assignees
@JoeCap08055
Labels
developer-portal
Milestone
Developer portal ...

Comments

@wilwade
Copy link
Collaborator

wilwade commented Oct 28, 2024 •
edited
Loading

See @claireolmstead if you need help with the style guide
@wilwade wilwade mentioned this issue Oct 28, 2024
Open
9 tasks
@JoeCap08055 JoeCap08055 self-assigned this Oct 28, 2024
@wilwade wilwade added this to the Developer portal updates milestone Oct 29, 2024
@JoeCap08055 JoeCap08055 mentioned this issue Oct 29, 2024
Merged
7 tasks
JoeCap08055 added a commit that referenced this issue Oct 30, 2024
@JoeCap08055
feat: swap in Footer component from @frequency-chain/style-guide (#43)
bc23068 
- also fix tailwindow.config.js to use 'extend' property, else Tailwind
classes from the package don't come through always


- Closes #36 

## Screenshot(s)

Desktop:

![image](https://github.com/user-attachments/assets/0cf2479b-0ab0-4dc9-a463-9858ed115259)

Mobile/small screen:

![image](https://github.com/user-attachments/assets/b6637fef-97be-422a-88cc-b00c59e00783)

Please delete options that are not relevant.

- [X] Content Change (Required approval in Slack: `#frequency-xyz` and
remember that changes along the way trigger
      re-approval.)
  - [ ] Approved HE (Required for technical wording)
  - [ ] Approved CM
  - [ ] Approved UO

# How to Test?
1. Pull branch
2. Run `npm run dev -- --open`
3. Visually verify that the footer matches the screenshots
4. 
# Checklist:

- [x] I have performed a self-review of my code
- [x] I have commented my code & PR, particularly in hard-to-understand
areas
- [x] I have checked at all the breakpoints to make sure it works on all
screen sizes
@wilwade
Copy link
Collaborator Author

wilwade commented Oct 30, 2024

Closed by #43

@wilwade wilwade closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeCap08055 JoeCap08055

Labels
developer-portal
Projects
None yet
Milestone
Developer portal updates
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/36-update-the-footer-with-the-one-from-the-style-guide frequency-chain/frequency-xyz
2 participants
@wilwade @JoeCap08055