ci(translation-tests): change filter prefix s/i18n/weblate/
#6985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weblate opens pull requests from weblate-fpf/securedrop@weblate-securedrop-securedrop.
legoktm
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
As described your PR accomplishes that so giving it my approval, but I guess I misinterpreted #6876 in thinking that we'd run translation-tests on every PR? Is there a reason we don't? Doing so would also be in line with #6980.
(Feel free to merge if you want to pick this up as a small change for now and leave dropping the branch filter entirely for the other ticket)
|
Actually, while debugging https://app.circleci.com/pipelines/github/freedomofpress/securedrop/6416/workflows/86ef51ed-fb3d-49c1-9f87-96d59e19dd2f/jobs/72712, I've realized this is wrong anyway: circleci@ip-10-0-25-2:~/project$ git branch
develop
* pull/6984
circleci@ip-10-0-25-2:~/project$ echo $CIRCLE_BRANCH
pull/6984
circleci@ip-10-0-25-2:~/project$ echo $CIRCLE_PR_USERNAME
weblate-fpfSo I'll have a fix for this fix shortly. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
After #6954, runs
translation-testson Weblate's pull requests prefixedweblate-rather than our custom branches prefixedi18n-.Testing
translation-tests.Deployment
No special considerations; CI-only.