Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n branches and/or repository should run full CI workflow #6876

Closed
cfm opened this issue Jun 22, 2023 · 1 comment · Fixed by #6923
Closed

i18n branches and/or repository should run full CI workflow #6876

cfm opened this issue Jun 22, 2023 · 1 comment · Fixed by #6923
Assignees
Labels
goals: sick CI i18n Anything related to translation or internationalization of SecureDrop

Comments

@cfm
Copy link
Member

cfm commented Jun 22, 2023

Description

In #6873 (specifically), we discovered the possibility of rare but obstructive partitions between the tooling that pushes to securedrop-i18n and the tests that run in securedrop. From the smallest to the largest possible solution to this problem:

  1. securedrop@i18n-* branches should run the full CI workflow in addition to the translation test suite.
  2. The securedrop-i18n repository itself should run full CI, including the translation test suite.
  3. After freedomofpress/securedrop-engineering#30, pull requests from Weblate into securedrop will run the full CI workflow like any other.

User Stories

As a maintainer, I want as few surprises as possible, especially on release day.

@cfm cfm added i18n Anything related to translation or internationalization of SecureDrop goals: sick CI labels Jun 22, 2023
@cfm cfm added this to the SecureDrop 2.7.0 milestone Jun 22, 2023
@legoktm
Copy link
Member

legoktm commented Jun 26, 2023

I think we should adopt 1) as a general policy - any commit slated to be merged into develop or a release branch must pass the full CI suite. I'm not really a fan of having special branch names trigger special jobs, ideally all tests should run always - are the translation tests too slow to run for every PR?

And of course we should do 3) too. :)

@zenmonkeykstop zenmonkeykstop moved this to Cycle Backlog in SecureDrop dev cycle Jul 12, 2023
@zenmonkeykstop zenmonkeykstop moved this from Cycle Backlog to Ready to go in SecureDrop dev cycle Aug 14, 2023
@cfm cfm moved this from Ready to go to In Progress in SecureDrop dev cycle Aug 16, 2023
@cfm cfm moved this from In Progress to Ready For Review in SecureDrop dev cycle Aug 16, 2023
@rocodes rocodes moved this from Ready For Review to Under Review in SecureDrop dev cycle Aug 21, 2023
@github-project-automation github-project-automation bot moved this from Under Review to Done in SecureDrop dev cycle Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goals: sick CI i18n Anything related to translation or internationalization of SecureDrop
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants