Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed version check for 'securedrop-admin verify' command #6134

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Removed version check for 'securedrop-admin verify' command #6134

merged 1 commit into from
Oct 12, 2021

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #6128

Testing

on a Tails admin workstation:

  • check out this branch
  • run `./securedrop-admin setup -t && ./securdrop-admin verify
  • Observe that the admin tool does not first check the securedrop version before running verify

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
  2. New installs.

Checklist

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

@zenmonkeykstop zenmonkeykstop requested a review from a team as a code owner October 9, 2021 17:06
@conorsch conorsch self-assigned this Oct 12, 2021
conorsch
conorsch approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. I'll handle backport momentarily

@conorsch conorsch merged commit 81576f6 into develop Oct 12, 2021
@conorsch conorsch mentioned this pull request Oct 12, 2021
Merged
2 tasks
@legoktm legoktm deleted the tails-verify-no-force-check branch January 9, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch conorsch approved these changes

Assignees

@conorsch conorsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] "securedrop-admin verify" does not support force arg
2 participants
@zenmonkeykstop @conorsch