Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] "securedrop-admin verify" does not support force arg #6128

Closed
conorsch opened this issue Oct 7, 2021 · 1 comment · Fixed by #6134
Closed

[QA] "securedrop-admin verify" does not support force arg #6128

conorsch opened this issue Oct 7, 2021 · 1 comment · Fixed by #6134

Comments

@conorsch
Copy link
Contributor

conorsch commented Oct 7, 2021

Description

Running ./securedrop-admin verify on release/2.1.0 fails, because there's no prod-signed tag on that commit.

Steps to Reproduce

  1. Check out release/2.1.0 in Tails, configured VMs
  2. Run ./securedrop-admin verify, observe error message and friendly recommendation to try the "--force" flag
  3. Run ./securedrop-admin --force verify as recommended, observe error message about flag not being understood

Expected Behavior

./securedrop-admin --force verify skips tag verification logic, just like ./securedrop-admin --force install does.

Actual Behavior

./securedrop-admin --force verify does not recognize the --force flag at all.

@zenmonkeykstop
Copy link
Contributor

IMO verify shouldn't do the version check at all - it doesn't run any playbook that can change the workstation or server state, so it doesn't matter which version you're on locally (altho the onus is then on the user to make sure they're using the version they expect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants