-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactors status-indicator img
s and related elements for ARIA labeling
#6021
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6021 +/- ##
========================================
Coverage 85.11% 85.11%
========================================
Files 55 55
Lines 3863 3863
Branches 479 479
========================================
Hits 3288 3288
Misses 463 463
Partials 112 112 Continue to review full report at Codecov.
|
Icon IMGs now carry their own TITLE tooltips, eliminating the SPAN elements originating in #382. Each LI.submission carries an ARIA label composed from those of its filename link, file-type icon, and read-state icon.
cbff6b9
to
94a5a3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as #6041 (comment) is addressed in a separate PR, I think this is ready to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Agree that the label semantics can be improved later, but Orca, at least, reads this current work well.
Status
Ready for review
Description of Changes
Resolves #5985.
This PR builds on #5996 to make more-meaningful use of both
alt
attributes (onimg
elements) andaria-*
annotations (onimg
and other elements) in those cases where an image indicates the status of another UI element. These images are not strictly decorative, but nor is their UI role communicated (and narrated by screen-readers) from functional markup such asbutton
elements. Instead, this more-nuanced refactoring (a) simplifies the existing markup (and narration) and (b) establishes narratable relationships between elements.This PR (especially cbff6b9) can be thought of as the prototype for the top-down semantic refactoring proposed in #5986 and #5987.
Testing
With a screen-reader running:
Deployment
No special considerations.
Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development container