UI refresh #382
Merged
UI refresh #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de javascript warning less obnoxious, and use less js dependencies.
|
Still not totally done yet, but much further. What's left:
|
Conflicts: securedrop/journalist_templates/base.html securedrop/source_templates/index.html securedrop/static/css/securedrop.css
|
This is all done. I didn't do much to make the journalist interface better because I don't want to step on @Hainish's work. I can make it look better later. |
| {% block header %} | ||
| <div id="header"> | ||
| <a href="/"><img src="/static/i/{{ header_image }}" alt="SecureDrop"></a> | ||
| <a href="/"><img src="/static/i/{{ header_image }}" class="logo small" alt="SecureDrop"></a> |
There was a problem hiding this comment.
Nit: should the alt message be "SecureDrop", or the name of org? That can be a follow-up (or we can just not bother).
There was a problem hiding this comment.
We don't know the name of org. :( Perhaps we will someday, when #344 is done.
| <h2>Remember this code and keep it secret</h2> | ||
| <p class="center">To protect your identity, we're assigning you a unique code name.</p> | ||
|
|
||
| <hr class="no-line" /> |
There was a problem hiding this comment.
It's quirky, but... I like it. This can stay, although I wonder if there is a better way.
| import datetime | ||
|
|
||
| def format_time(d): | ||
| return d.strftime('%b %d, %Y %I:%M %p') |
There was a problem hiding this comment.
PEP8 demands 4-space indentation (which is also consistent with the rest of the codebase).
|
|
Conflicts: securedrop/journalist.py securedrop/static/css/securedrop.css
Closed
cfm
added a commit
that referenced
this pull request
Jun 24, 2021
Icon IMGs now carry their own TITLE tooltips, eliminating the SPAN elements originating in #382. Each li.submission carries an ARIA label composed from those of its filename link, file-type icon, and read-state icon.
cfm
added a commit
that referenced
this pull request
Jun 24, 2021
Icon IMGs now carry their own TITLE tooltips, eliminating the SPAN elements originating in #382. Each li.submission carries an ARIA label composed from those of its filename link, file-type icon, and read-state icon.
cfm
added a commit
that referenced
this pull request
Jun 24, 2021
Icon IMGs now carry their own TITLE tooltips, eliminating the SPAN elements originating in #382. Each LI.submission carries an ARIA label composed from those of its filename link, file-type icon, and read-state icon.
cfm
added a commit
that referenced
this pull request
Jun 29, 2021
Icon IMGs now carry their own TITLE tooltips, eliminating the SPAN elements originating in #382. Each LI.submission carries an ARIA label composed from those of its filename link, file-type icon, and read-state icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial pull request for the new UI (#329) so that others can get to work with what I've done. Most notably:
Here are things to note:
source_templates/index.html, which doesn't usebase.htmlbecause the index page has a different layout now.Here are things that aren't yet done in the source interface:
securedrop/config/custom_theme_image.py) don't work anymore, right now I've just hard-coded the SecureDrop logo there. There's commented out code at the bottom ofsource_templates/base.htmlfor using the custom header images, but I haven't made it work yet.I think that's it. All the tests pass too. (Maybe we should write a custom header test?)