Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the systemd-timesyncd service is not masked #5842

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Mar 3, 2021

Status

Ready for review

Description of Changes

Explicitly unmasks the systemd-timesyncd service.

Fixes #5840.

Testing

  • Build a Focal staging environment, or install on hardware.
  • On both servers:
    • Ensure that systemctl list-unit-files --state=masked | grep time reports nothing.
    • systemctl list-unit-files systemd-timesyncd.service should report that the service is enabled.
    • systemctl status systemd-timesyncd should report that it is enabled and loaded.

Deployment

No new concerns.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fine to merge when CI passes.

@rmol rmol merged commit 1af31d2 into develop Mar 3, 2021
@rmol rmol deleted the ensure-timesyncd-unmasked branch March 3, 2021 22:34
kushaldas added a commit that referenced this pull request Mar 4, 2021
[1.8.0] Backport #5842 (Ensure the systemd-timesyncd service is not masked)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Focal) Failure enabling systemd-timesyncd: "service is masked"
3 participants