Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Focal) Failure enabling systemd-timesyncd: "service is masked" #5840

Closed
rocodes opened this issue Mar 3, 2021 · 6 comments · Fixed by #5842
Closed

(Focal) Failure enabling systemd-timesyncd: "service is masked" #5840

rocodes opened this issue Mar 3, 2021 · 6 comments · Fixed by #5842

Comments

@rocodes
Copy link
Contributor

rocodes commented Mar 3, 2021

Description

Installing SecureDrop 1.8.0-rc1 on Focal on hardware (NUC7s), I'm consistently encountering an error during the Ensure systemd-timesyncd service is enabled task:

Unable to enable service systemd-timesyncd: Failed to enable unit: Unit file /etc/systemd/system/systemd-timesyncd.service is masked.

Steps to Reproduce

  • Install Focal on hardware
  • Fresh clone of SD repo, (reuse tor_v3_keys.json)
  • Checkout 1.8.0-rc1 and modify install-fpf-repo/...main.yml to use apt-test repo and apt-test key as per QA procedures
  • Complete pre-install steps then install from scratch using ./securedrop-admin --force install.

Expected Behavior

1.8.0-rc1 installed on servers

Actual Behavior

On both app and mon:
Unable to enable service systemd-timesyncd: Failed to enable unit: Unit file /etc/systemd/system/systemd-timesyncd.service is masked.

@zenmonkeykstop
Copy link
Contributor

FWIW I did not observe this during my most recent install, and the service is up and running on my boxen.

@rmol
Copy link
Contributor

rmol commented Mar 3, 2021

I am so far unable to reproduce the error; my test run had no problem with Ensure systemd-timesyncd service is enabled.

@conorsch
Copy link
Contributor

conorsch commented Mar 3, 2021

I haven't seen this, either. However, it might be worthwhile explicitly setting masked: no on the relevant task: https://github.com/freedomofpress/securedrop/pull/5806/files#diff-ae5be923cdf2cac58831b9ea69297001a39085628927b7c6a55e4a994f41803fR76-R81

@rocodes
Copy link
Contributor Author

rocodes commented Mar 3, 2021

I'm going to reinstall Focal and see if even I can repro. (My reference to "consistently" was on repeated install attempts, but I'll try wiping now)

@rocodes
Copy link
Contributor Author

rocodes commented Mar 3, 2021

I wiped and reinstalled Focal and 1.8.0-rc1 did not reproduce my original issue. Maintainers feel free to close if you wish.

@rmol
Copy link
Contributor

rmol commented Mar 3, 2021

@conorsch I added #5842 to unmask the service. Don't think it's strictly necessary, but wouldn't hurt either, other than the extra review and testing time.

@rmol rmol closed this as completed in #5842 Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants