Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables LTS upgrade prompt for Focal #5786

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

conorsch
Copy link
Contributor

Status

Work in progress

Description of Changes

We don't want the OS to nag admins, since we want to ensure the next LTS
is fully supported by SecureDrop before recommending an in-place
upgrade. Disable the prompt on Focal, same as we've done for Xenial in
the past.

Closes #5782.

Testing

Still need to update the testinfra tests.

Deployment

TK

@conorsch conorsch self-assigned this Feb 11, 2021
@conorsch
Copy link
Contributor Author

No test updates are required, since the tests were already failing, although not in CI. I'm going to wait a bit longer until #5784 is in, then rebase this one, which should get 100% of the Focal tests passing on Qubes ISO-based VMs.

@emkll emkll force-pushed the 5782-disable-lts-updates-for-focal branch from 84f5447 to a959b25 Compare February 12, 2021 15:15
@emkll
Copy link
Contributor

emkll commented Feb 12, 2021

Rebased on latest develop after merging #5784

We don't want the OS to nag admins, since we want to ensure the next LTS
is fully supported by SecureDrop before recommending an in-place
upgrade. Disable the prompt on Focal, same as we've done for Xenial in
the past.

Closes #5782.
@conorsch conorsch force-pushed the 5782-disable-lts-updates-for-focal branch from a959b25 to 6b2badb Compare February 12, 2021 16:51
@emkll emkll marked this pull request as ready for review February 12, 2021 18:35
@kushaldas kushaldas self-assigned this Feb 15, 2021
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as in intended on Focal in both app and mon servers.

@kushaldas kushaldas merged commit a27a567 into develop Feb 15, 2021
@kushaldas kushaldas deleted the 5782-disable-lts-updates-for-focal branch February 15, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Focal] LTS channel allowed for upgrades
3 participants