Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Focal] LTS channel allowed for upgrades #5782

Closed
conorsch opened this issue Feb 9, 2021 · 1 comment · Fixed by #5786
Closed

[Focal] LTS channel allowed for upgrades #5782

conorsch opened this issue Feb 9, 2021 · 1 comment · Fixed by #5786

Comments

@conorsch
Copy link
Contributor

conorsch commented Feb 9, 2021

Description

The release management settings for Focal permit do-release-upgrade to the next LTS version. There isn't one of those yet, but tests are failing because of it:

        def test_release_manager_upgrade_channel(host):
            """
            Ensures that the `do-release-upgrade` command will not
            suggest upgrades from Xenial to Bionic (which is untested
            and unsupported.)
            """
            expected_channels = {
                "xenial": "never",
                "focal": "never",
            }
    
            config_path = "/etc/update-manager/release-upgrades"
            assert host.file(config_path).is_file
    
            raw_output = host.check_output("grep '^Prompt' {}".format(config_path))
            _, channel = raw_output.split("=")
    
            expected_channel = expected_channels[host.system_info.codename]
    >       assert channel == expected_channel
    E       AssertionError: assert 'lts' == 'never'
    E         - never
    E         + lts

To see that test fail, you'll need to use hardware or Qubes VMs (installed from ISO), since the bento boxes modify the setting https://github.com/chef/bento/blob/3dd165cf422572ab4240c8f1ce9a7e40b7960457/packer_templates/ubuntu/scripts/update.sh#L5 in a similar fashion to what we implemented for Xenial in https://github.com/freedomofpress/securedrop/pull/3546/files

Comments

This is almost certainly a duplicate of #5781, but filing separately until that's confirmed.

@emkll
Copy link
Contributor

emkll commented Feb 9, 2021

This test failure is due to changes introduced by https://github.com/freedomofpress/securedrop/pull/5684/files

The securedrop-config (focal) package no longer contains some of the historical changes we've made on long running instances via securedrop-config postinst.

The xenial postinst, containing historical changes: https://github.com/freedomofpress/securedrop/blob/develop/install_files/securedrop-config/DEBIAN/postinst
The (streamlined) focal postinst: https://github.com/freedomofpress/securedrop/blob/develop/install_files/securedrop-config-focal/DEBIAN/postinst .

We can update that string ansible (or via postinst) if strictly necessary for 1.8.0

conorsch pushed a commit that referenced this issue Feb 11, 2021
We don't want the OS to nag admins, since we want to ensure the next LTS
is fully supported by SecureDrop before recommending an in-place
upgrade. Disable the prompt on Focal, same as we've done for Xenial in
the past.

Closes #5782.
emkll pushed a commit that referenced this issue Feb 12, 2021
We don't want the OS to nag admins, since we want to ensure the next LTS
is fully supported by SecureDrop before recommending an in-place
upgrade. Disable the prompt on Focal, same as we've done for Xenial in
the past.

Closes #5782.
conorsch pushed a commit that referenced this issue Feb 12, 2021
We don't want the OS to nag admins, since we want to ensure the next LTS
is fully supported by SecureDrop before recommending an in-place
upgrade. Disable the prompt on Focal, same as we've done for Xenial in
the past.

Closes #5782.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants