Fixes #5378, adds more checks for invalid username #5380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #5284 we made sure that the username `deleted` is not not allowed to be added in the system via the admin section of the journalist web application. But, one could still edit any existing user and change the name to `deleted`. Or, an admin can add a new user via `manage.py` in command line. In PR adds checks to make sure that addiving a new user via `manage.py` will fail if you try to set the username as `deleted`, it also blocks editing any existing username to `deleted`. The PR also includes unit and functional tests.
kushaldas
force-pushed
the
more_checks_invalid_username
branch
from
32e6ead to
90e19ea
Compare
rmol
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
👍
-
make build-debs -
make staging - Run
create-dev-data.pyin theapp-stagingvm for 2 journalists accounts. - Try to add a new user called
deletedviamanage.py, this should fail. - Login as
journalistand then try to change the usernamedellsbergtodeleted, this should flash an error about "Invalid username"
kushaldas
added a commit
that referenced
this pull request
Jul 16, 2020
Cherry pick #5380 to release/1.5.0
Closed
sssoleileraaa
pushed a commit
that referenced
this pull request
Aug 31, 2020
…name Fixes #5378, adds more checks for invalid username
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review.
Description of Changes
Fixes #5378
In #5284 we made sure that the username
deletedis not not allowedto be added in the system via the admin section of the journalist web
application. But, one could still edit any existing user and change
the name to
deleted. Or, an admin can add a new user viamanage.pyin command line.
In PR adds checks to make sure that addiving a new user via
manage.pywill fail if you try to set the username as
deleted, it also blocksediting any existing username to
deleted.The PR also includes unit and functional tests.
Testing
make build-debsmake stagingcreate-dev-data.pyin theapp-stagingvm for 2 journalists accounts.deletedviamanage.py, this should fail.journalistand then try to change the usernamedellsbergtodeleted, this should flash an error about "Invalid username"Deployment
Any special considerations for deployment? Consider both:
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locallyIf you added or updated a code dependency:
Choose one of the following: