A couple of ideas for better handling of deleted journalists #5378
Assignees
Comments
kushaldas
added a commit
that referenced
this issue
Jul 16, 2020
In #5284 we made sure that the username `deleted` is not not allowed to be added in the system via the admin section of the journalist web application. But, one could still edit any existing user and change the name to `deleted`. Or, an admin can add a new user via `manage.py` in command line. In PR adds checks to make sure that addiving a new user via `manage.py` will fail if you try to set the username as `deleted`, it also blocks editing any existing username to `deleted`. The PR also includes unit and functional tests.
12 tasks
kushaldas
added a commit
that referenced
this issue
Jul 16, 2020
In #5284 we made sure that the username `deleted` is not not allowed to be added in the system via the admin section of the journalist web application. But, one could still edit any existing user and change the name to `deleted`. Or, an admin can add a new user via `manage.py` in command line. In PR adds checks to make sure that addiving a new user via `manage.py` will fail if you try to set the username as `deleted`, it also blocks editing any existing username to `deleted`. The PR also includes unit and functional tests.
rmol
added a commit
that referenced
this issue
Jul 16, 2020
…name Fixes #5378, adds more checks for invalid username
rmol
pushed a commit
that referenced
this issue
Jul 16, 2020
In #5284 we made sure that the username `deleted` is not not allowed to be added in the system via the admin section of the journalist web application. But, one could still edit any existing user and change the name to `deleted`. Or, an admin can add a new user via `manage.py` in command line. In PR adds checks to make sure that addiving a new user via `manage.py` will fail if you try to set the username as `deleted`, it also blocks editing any existing username to `deleted`. The PR also includes unit and functional tests. (cherry picked from commit 90e19ea)
sssoleileraaa
pushed a commit
that referenced
this issue
Aug 31, 2020
…name Fixes #5378, adds more checks for invalid username
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
After #5284, you can no longer create a journalist account with a username of "deleted" in the journalist interface admin section, but in review we missed the fact that you can change an existing account's username to that.
It's also still possible to use
manage.pyto create an account with a username of "deleted".The text was updated successfully, but these errors were encountered: