[1.3.0] Backport use of WTForm for source interface submission form #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds SubmissionForm to securedrop/source_app/forms.py, supporting validation of the source submission form. Rework lookup.html to use it: some presentation (the placeholder) had to be moved to the form, because the translated message couldn't be interpolated into the SubmissionForm construction in the template. Note that this change does *not* add the maxlength attribute to the message textarea, as Firefox doesn't limit the text length accurately when it includes newlines and can submit a message longer than the validator limit. (cherry picked from commit 412103d)
zenmonkeykstop
requested review from
conorsch,
emkll,
kushaldas and
redshiftzero
as code owners
emkll
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Backports #5226.
Backports the PR to use WTForm for the source interface submission form, enforcing a max length of 100000 chars on message submissions.
Testing