Use WTForm for source interface submission form #5226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmol
force-pushed
the
source-submission-wtform
branch
from
cf315b7 to
4a370f4
Compare
Adds SubmissionForm to securedrop/source_app/forms.py, supporting validation of the source submission form. Rework lookup.html to use it: some presentation (the placeholder) had to be moved to the form, because the translated message couldn't be interpolated into the SubmissionForm construction in the template. Note that this change does *not* add the maxlength attribute to the message textarea, as Firefox doesn't limit the text length accurately when it includes newlines and can submit a message longer than the validator limit.
rmol
force-pushed
the
source-submission-wtform
branch
from
4a370f4 to
412103d
Compare
zenmonkeykstop
approved these changes
May 4, 2020
There was a problem hiding this comment.
As per test plan:
- Check out the source-submission-wtform branch.
- Run make dev
- Navigate to the source submission page.
- Copy more than 100000 bytes of text, paste it into the message textarea, submit, and confirm that you get an error saying Message text too long. Large blocks of text must be uploaded as a file, not copied and pasted.
- Submit a short message and confirm that there is no validation error.
- Confirm that you can still upload a file larger than 100000 bytes.
- Navigate to the journalist interface, under the instance config admin page, and disable uploads.
- Retry the large paste test, and confirm that the message is simply Message text too long.
Diff review also LGTM!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Adds
SubmissionFormtosecuredrop/source_app/forms.py, supporting validation of the source submission form. Reworklookup.htmlto use it: some presentation (the placeholder) had to be moved to the form, because the translated message couldn't be interpolated into theSubmissionFormconstruction in the template.Note that this change does not add the
maxlengthattribute to the message textarea, as Firefox doesn't limit the text length accurately when it includes newlines and can submit a message longer than the validator limit.Testing
source-submission-wtformbranch.make devMessage text too long. Large blocks of text must be uploaded as a file, not copied and pasted.Message text too long.Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made non-trivial code changes: