Update default staging target to Xenial #4311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloquence
requested review from
conorsch,
emkll,
kushaldas and
msheiny
as code owners
conorsch
suggested changes
Apr 3, 2019
There was a problem hiding this comment.
We also need to update the overrides in the staging scenarios themselves, given that we were leveraging this "Trusty" default to determine which packages we should install against Trusty or Xenial hosts. To illustrate the error:
rm -rf build/*
make staging-trusty
Observe error about lack of Xenial debs—it should be looking for Trusty debs! I'll append a commit to resolve prior to approval.
The "default" target distro for staging is now Xenial, which means we need to tweak the overrides in the various staging-related Molecule scenarios. Overrides are in place to force Trusty, and overrides referencing Xenial are removed, due to the new default behavior.
conorsch
approved these changes
Apr 3, 2019
emkll
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4310
Status
Ready for review
If you made changes to the system configuration:
(Staging VMs are provisioned and working, but testinfra tests are failing locally for me - most likely unrelated.)