Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default staging target to Xenial #4310

Closed
eloquence opened this issue Apr 1, 2019 · 1 comment
Closed

Update default staging target to Xenial #4310

eloquence opened this issue Apr 1, 2019 · 1 comment
Labels

Comments

@eloquence
Copy link
Member

The securedrop_staging_install_target_distro is currently set to trusty in
https://github.com/freedomofpress/securedrop/blob/develop/install_files/ansible-base/group_vars/all/securedrop . This needs to be changed to xenial as part of #4155.

@eloquence eloquence added the bug label Apr 1, 2019
@eloquence
Copy link
Member Author

eloquence commented Apr 1, 2019

In building the staging environment for Xenial with the virtualbox provider, I encountered an error during provisioning (it failed to locate the trusty packages, since the packages built during the make build-debs step were for xenial) that I traced down to this variable. What's not clear to me is why this error occurred at all, since it appears that we override this variable both for libvirt and virtualbox:

https://github.com/freedomofpress/securedrop/blob/develop/molecule/virtualbox-staging-xenial/ansible-override-vars.yml

https://github.com/freedomofpress/securedrop/blob/develop/molecule/libvirt-staging-xenial/ansible-override-vars.yml#L9

Regardless, it clearly shouldn't be trusty, so I'll submit a PR to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant