Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kernels to 4.4.167 and remove wireless support #4002

Merged
merged 2 commits into from
Jan 8, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Dec 20, 2018

Status

Ready for review

❗ Before merge, please review the following PR (contains the config of the 4.4.167 SecureDrop kernel):

Description of Changes

Fixes #2726 .

Removes wireless support from the kernel, bumps version to 4.4.167. Adds tests to ensure the configuration is properly applied.

Testing

  1. Review kernel configuration in Remove wireless support in securedrop kernel config ansible-role-grsecurity-build#42
  2. Provision staging and run infra tests, and observe no failures:
    ======== 446 passed, 13 skipped, 8 xfailed, 2 xpassed in 135.22 seconds ========
  1. Syslog should not contain any error messages
  2. If testing on hardware, please report findings on this ticket (I have tested on NUC 5PYH and the Kernel works as expected).
  3. Ensure test coverage for configuration is adequate

Deployment

New and existing installs will be handled by the deb packages hosted on the apt server.

Checklist

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Also removes 4.4.144 kernels
Ensures wireless functionality is disabled.
@conorsch
Copy link
Contributor

conorsch commented Jan 7, 2019

Proceeding with VM-based review now, progress:

    ======== 446 passed, 13 skipped, 8 xfailed, 2 xpassed in 135.22 seconds ========
  • Syslog should not contain any error messages
  • 🔶 Not testing hardware If testing on hardware, please report findings on this ticket (I have tested on NUC 5PYH and the Kernel works as expected).
  • Ensure test coverage for configuration is adequate

Deployment

Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good here. Only performed VM-based testing, so a bit more scrutiny is warranted here; tagging @zenmonkeykstop for a follow-up on Mac Mini hardware, to make sure there aren't any surprises.

@zenmonkeykstop
Copy link
Contributor

zenmonkeykstop commented Jan 8, 2019

Did a fresh install from apt-test on 2014 Mac Minis and checked basic server settings:

  • uname -r reports kernel 4.4.167-grsec
  • paxtest blackhat and meltdown test script results are the same as for previous kernel version
  • wireless modules not found under /lib/modules/4.4.162/kernel/
  • manual check of grsec config file in /boot matches what's expected from the infra test.
  • nothing relevant in syslog
  • source submissions, admin user setup and login work.

LGTM!

@emkll
Copy link
Contributor Author

emkll commented Jan 8, 2019

thanks @zenmonkeykstop and @conorsch for the review/testing, merging this now. As stated previously, debs are live on apt-test.

@emkll emkll merged commit 66e3607 into develop Jan 8, 2019
@emkll emkll deleted the 2726-update-kernel-to-4.4.167 branch January 8, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants